Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getOptionValues does not filter by ID #169

Open
bc-jz opened this issue Mar 31, 2016 · 0 comments
Open

getOptionValues does not filter by ID #169

bc-jz opened this issue Mar 31, 2016 · 0 comments

Comments

@bc-jz
Copy link
Contributor

bc-jz commented Mar 31, 2016

https://github.com/bigcommerce/bigcommerce-api-php/blob/master/src/Bigcommerce/Api/Client.php#L676-L680

This getOptionValues() function does not filter by an Option ID, this seems to be contradictory to how we built out similar functions such as getOrderProducts(). I think we should update getOptionValues() to accept an ID and include that in it's request if so.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bc-jz