Skip to content

Commit 5757220

Browse files
Merge pull request #1822 from BC-tymurbiedukhin/BCTHEME-211
fix(storefront): BCTHEME-211 Cross icon on close button missalignment
2 parents 4077248 + 94d9c30 commit 5757220

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# Changelog
22

3+
- Cross icon on close button missalignment. [#1822](https://github.com/bigcommerce/cornerstone/pull/1822)
4+
35
## Draft
46
- Face accessibility standards with social links on PDP's page. [#1809](https://github.com/bigcommerce/cornerstone/pull/1809)
57
- State of search link not announced. [#1798](https://github.com/bigcommerce/cornerstone/pull/1798)

assets/scss/components/foundation/modal/_modal.scss

-4
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,6 @@
8383
}
8484

8585
@include addFocusTooltip;
86-
87-
&__aria-text {
88-
font-size: 0;
89-
}
9086
}
9187

9288
.modal-body {

templates/components/common/modal/modal-close-btn.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
title="{{lang 'common.close'}}"
44
{{additional_attr}}
55
>
6-
<span class="modal-close__aria-text">{{lang 'common.close'}}</span>
6+
<span class="aria-description--hidden">{{lang 'common.close'}}</span>
77
<span aria-hidden="true">&#215;</span>
88
</button>

0 commit comments

Comments
 (0)