Skip to content

Commit 5acc434

Browse files
author
“bc-yevhenii-buliuk”
committed
fix(storefront): BCTHEME-909 Social media icons failing wave scan with Empty Link.
1 parent 7093931 commit 5acc434

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

77
## Draft
8+
- Social media icons failing wave scan with "Empty Link". [#2202](https://github.com/bigcommerce/cornerstone/issues/2202)
89

910
## 6.3.0 (03-11-2022)
1011
- Update blog component to use H1 tags on posts [#2179](https://github.com/bigcommerce/cornerstone/issues/2179)

templates/components/common/social-links.html

+10-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,16 @@
22
<ul class="socialLinks socialLinks--alt">
33
{{#each social_media}}
44
<li class="socialLinks-item">
5-
<a class="icon icon--{{display_name}}" href="{{url}}" target="_blank" rel="noopener">
6-
<svg><use xlink:href="#icon-{{display_name}}" /></svg>
5+
<a class="icon icon--{{display_name}}"
6+
href="{{url}}"
7+
target="_blank"
8+
rel="noopener"
9+
title="{{{capitalize display_name}}}"
10+
>
11+
<span class="aria-description--hidden">{{{capitalize display_name}}}</span>
12+
<svg>
13+
<use xlink:href="#icon-{{display_name}}"/>
14+
</svg>
715
</a>
816
</li>
917
{{/each}}

0 commit comments

Comments
 (0)