Skip to content

Commit e07592e

Browse files
author
Tolu Abayomi
authored
Merge pull request #1113 from tabayomi/STENCIL-3567-facet-spaces
fix(storefront): STENCIL-3567 Fix spaces in faceted search option names
2 parents c53c77f + 8fbbd87 commit e07592e

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

‎templates/components/faceted-search/facets/hierarchy.html

+5-5
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<div
44
class="accordion-navigation toggleLink {{#unless ../start_collapsed }} is-open {{/unless}}"
55
role="button"
6-
data-collapsible="#facetedSearch-content--{{ facet }}">
6+
data-collapsible="#facetedSearch-content--{{hyphenate facet }}">
77
<h5 class="accordion-title">
88
{{ title }}
99
</h5>
@@ -21,12 +21,12 @@ <h5 class="accordion-title">
2121
</div>
2222
</div>
2323

24-
<div id="facetedSearch-content--{{ facet }}" class="accordion-content {{#unless ../start_collapsed }} is-open {{/unless}}">
25-
<ul id="facetedSearch-navList--{{ facet }}" class="navList" data-facet="{{facet}}" data-has-more-results="{{ has_more_results }}">
24+
<div id="facetedSearch-content--{{hyphenate facet }}" class="accordion-content {{#unless ../start_collapsed }} is-open {{/unless}}">
25+
<ul id="facetedSearch-navList--{{hyphenate facet }}" class="navList" data-facet="{{facet}}" data-has-more-results="{{ has_more_results }}">
2626
{{#each items}}
2727
<li class="navList-item">
2828
<a
29-
href="{{url}}"
29+
href="{{ url }}"
3030
class="navList-action navList-action--checkbox {{#if selected }} is-selected {{/if}} {{#if has_sub_categories }} has-children {{/if}}"
3131
rel="nofollow"
3232
data-id="{{ id }}"
@@ -46,7 +46,7 @@ <h5 class="accordion-title">
4646
</ul>
4747

4848
{{#if show_more_toggle}}
49-
<a href="#facetedSearch-navList--{{ facet }}" role="button" class="toggleLink">
49+
<a href="#facetedSearch-navList--{{hyphenate facet }}" role="button" class="toggleLink">
5050
<span class="toggleLink-text toggleLink-text--off">{{lang 'search.faceted.show-more'}}</span>
5151
</a>
5252
{{/if}}

‎templates/components/faceted-search/facets/multi.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<div
44
class="accordion-navigation toggleLink {{#unless ../start_collapsed }} is-open {{/unless}}"
55
role="button"
6-
data-collapsible="#facetedSearch-content--{{ facet }}">
6+
data-collapsible="#facetedSearch-content--{{hyphenate facet }}">
77
<h5 class="accordion-title">
88
{{ title }}
99
</h5>
@@ -21,8 +21,8 @@ <h5 class="accordion-title">
2121
</div>
2222
</div>
2323

24-
<div id="facetedSearch-content--{{ facet }}" class="accordion-content {{#unless ../start_collapsed }} is-open {{/unless}}">
25-
<ul id="facetedSearch-navList--{{ facet }}" data-facet="{{facet}}" class="navList" data-has-more-results="{{ has_more_results }}">
24+
<div id="facetedSearch-content--{{hyphenate facet }}" class="accordion-content {{#unless ../start_collapsed }} is-open {{/unless}}">
25+
<ul id="facetedSearch-navList--{{hyphenate facet }}" data-facet="{{facet}}" class="navList" data-has-more-results="{{ has_more_results }}">
2626
{{#each items}}
2727
<li class="navList-item">
2828
<a
@@ -46,7 +46,7 @@ <h5 class="accordion-title">
4646
</ul>
4747

4848
{{#if show_more_toggle}}
49-
<a href="#facetedSearch-navList--{{ facet }}" role="button" class="toggleLink">
49+
<a href="#facetedSearch-navList--{{hyphenate facet }}" role="button" class="toggleLink">
5050
<span class="toggleLink-text toggleLink-text--off">{{lang 'search.faceted.show-more'}}</span>
5151
</a>
5252
{{/if}}

‎templates/components/faceted-search/facets/range.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<div
33
class="accordion-navigation toggleLink {{#unless ../start_collapsed }} is-open {{/unless}}"
44
role="button"
5-
data-collapsible="#facetedSearch-content--{{ facet }}">
5+
data-collapsible="#facetedSearch-content--{{hyphenate facet }}">
66
<h5 class="accordion-title">
77
{{ title }}
88
</h5>
@@ -20,7 +20,7 @@ <h5 class="accordion-title">
2020
</div>
2121
</div>
2222

23-
<div id="facetedSearch-content--{{ facet }}" class="accordion-content {{#unless ../start_collapsed }} is-open {{/unless}}">
23+
<div id="facetedSearch-content--{{hyphenate facet }}" class="accordion-content {{#unless ../start_collapsed }} is-open {{/unless}}">
2424
<form id="facet-range-form" class="form" method="get" data-faceted-search-range novalidate>
2525
{{#each current_selected_items}}
2626
<input type="hidden" name="{{ param_name }}[]" value="{{ param_value }}"/>

‎templates/components/faceted-search/facets/rating.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<div
44
class="accordion-navigation toggleLink {{#unless ../start_collapsed }} is-open {{/unless}}"
55
role="button"
6-
data-collapsible="#facetedSearch-content--{{ facet }}">
6+
data-collapsible="#facetedSearch-content--{{hyphenate facet }}">
77
<h5 class="accordion-title">
88
{{ title }}
99
</h5>
@@ -21,7 +21,7 @@ <h5 class="accordion-title">
2121
</div>
2222
</div>
2323

24-
<div id="facetedSearch-content--{{ facet }}" class="accordion-content facetedSearch-content--{{ facet }} {{#unless ../start_collapsed }} is-open {{/unless}}">
24+
<div id="facetedSearch-content--{{hyphenate facet }}" class="accordion-content facetedSearch-content--{{hyphenate facet}} {{#unless ../start_collapsed }} is-open {{/unless}}">
2525
<ul class="navList">
2626
{{#each items}}
2727
<li class="navList-item">

0 commit comments

Comments
 (0)