Skip to content

Commit f19db83

Browse files
author
bc-zoharmuzafi
authored
Merge pull request #1323 from bc-zoharmuzafi/amp-page-error
Amp page error
2 parents 72e2cc7 + 32883ce commit f19db83

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## Draft
44
- Fix encoding issues on Account Signup Form ("'" characters showing in country name)[#1341] (https://github.com/bigcommerce/cornerstone/pull/1341)
55
- Require Webpack config only when used (reduce time to be ready for receiving messages from stencil-cli). [#1334](https://github.com/bigcommerce/cornerstone/pull/1334)
6+
- Fixed amp page error related to store logo [#1323](https://github.com/bigcommerce/cornerstone/pull/1323)
67

78
## 2.3.2 (2018-08-17)
89
- Fix zoom behavior for small images in gallery (turn off zoom if image is too small). [#1325](https://github.com/bigcommerce/cornerstone/pull/1325)

templates/components/amp/common/store-logo.html

+5-1
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,12 @@
77
{{else}}
88
width="{{first (split theme_settings.logo_size 'x')}}"
99
height="{{last (split theme_settings.logo_size 'x')}}"
10+
{{#if (last (split theme_settings.logo_size 'x')) 'gtnum' (first (split theme_settings.logo_size 'x')) }}
11+
sizes="(max-width: 360px) 100vw, 1vw"
12+
{{else}}
13+
sizes="(max-width: 360px) 100vw, 10vw"
14+
{{/if}}
1015
layout="responsive"
11-
sizes="(min-height: {{last (split theme_settings.logo_size 'x')}}%)"
1216
{{/if}}
1317
alt="{{settings.store_logo.title}}">
1418
</amp-img>

0 commit comments

Comments
 (0)