Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List View - Description - Fix Special Characters and Line Returns #970

Closed
GeorgeLondon opened this issue Mar 17, 2017 · 7 comments
Closed
Assignees

Comments

@GeorgeLondon
Copy link

GeorgeLondon commented Mar 17, 2017

Great to have a List View now, thanks (fixed in STENCIL-3194) - I've just activated it in our test store.

You can see from the below screenshot that special characters are not displaying correctly. Not using the H4 formatting is probably OK, but the line returns should be acknowledged - if not as returns, then with some kind of separator.

image

Second screenshot shows what that description looks like on the Product page with all of its formatted text intact. (Note - the product name "Kiwi Shoe Polish GSG" is further up the page offscreen in this screenshot, but it is displaying OK.)

image

All screenshots from Win10/Chrome.

@PreciselyAlyss
Copy link
Contributor

For a quick fix, you just need to add an extra set of brackets around the description to properly escape html such as {{{product.description}}}

Thanks for the report!

@GeorgeLondon
Copy link
Author

Thanks for your response. You're suggesting that I "add brackets" where?

@PreciselyAlyss
Copy link
Contributor

you'd need to add brackets around the summary, but you can see my fix linked above.

@GeorgeLondon
Copy link
Author

GeorgeLondon commented Mar 28, 2017

Sorry - I don't really understand how this all works... so should your fix now be in the software?
I'm still seeing the same issue so either your fix hasn't been applied yet or isn't working.

I tried adding curly brackets to the product description but they were just displayed along with the rest of the text.

For now I've removed any (c) signs I could find, and replaced apostrophes with non-problematic ones.

@GeorgeLondon
Copy link
Author

OK - I found and edited the file at templates/components/products/list-item.html and that's fixed it. Hopefully this will be fixed in the next release of the theme. I very much appreciate your help.

Oh - do you not agree that the line-returns should be acknowledged in this view? I guess that's a design decision rather than necessarily a big... what's your opinion?

@PreciselyAlyss
Copy link
Contributor

@GeorgeLondon I personally don't feel that they should because this is meant to keep a uniform design, though I understand it can be confusing visually for a customer. It is really up to a priority of aesthetics and concisely presented information.

For this theme, we are trying to make something agnostic that could be used by anyone or built upon.

@PreciselyAlyss
Copy link
Contributor

@GeorgeLondon my fix should be live relatively soon. You can check the changelog/releases for more info about when it'll be available or you can modify your theme to include it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants