-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List View - Description - Fix Special Characters and Line Returns #970
Comments
For a quick fix, you just need to add an extra set of brackets around the description to properly escape html such as Thanks for the report! |
Thanks for your response. You're suggesting that I "add brackets" where? |
you'd need to add brackets around the summary, but you can see my fix linked above. |
Sorry - I don't really understand how this all works... so should your fix now be in the software? I tried adding curly brackets to the product description but they were just displayed along with the rest of the text. For now I've removed any (c) signs I could find, and replaced apostrophes with non-problematic ones. |
OK - I found and edited the file at templates/components/products/list-item.html and that's fixed it. Hopefully this will be fixed in the next release of the theme. I very much appreciate your help. Oh - do you not agree that the line-returns should be acknowledged in this view? I guess that's a design decision rather than necessarily a big... what's your opinion? |
@GeorgeLondon I personally don't feel that they should because this is meant to keep a uniform design, though I understand it can be confusing visually for a customer. It is really up to a priority of aesthetics and concisely presented information. For this theme, we are trying to make something agnostic that could be used by anyone or built upon. |
@GeorgeLondon my fix should be live relatively soon. You can check the changelog/releases for more info about when it'll be available or you can modify your theme to include it. |
Great to have a List View now, thanks (fixed in STENCIL-3194) - I've just activated it in our test store.
You can see from the below screenshot that special characters are not displaying correctly. Not using the H4 formatting is probably OK, but the line returns should be acknowledged - if not as returns, then with some kind of separator.
Second screenshot shows what that description looks like on the Product page with all of its formatted text intact. (Note - the product name "Kiwi Shoe Polish GSG" is further up the page offscreen in this screenshot, but it is displaying OK.)
All screenshots from Win10/Chrome.
The text was updated successfully, but these errors were encountered: