Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: regress.py lookup of executable directory is unnecessarily complex #67

Open
michael-okeefe opened this issue May 7, 2024 · 0 comments
Labels
enhancement New feature or request low-priority "Nice to have" but not necessary; prioritize lower

Comments

@michael-okeefe
Copy link
Member

Problem

The regression test file docs/examples/regress.py uses an unnecessarily complex mechanism to guess where the bin directory is for the ERIN executables. However, CMake is capable of providing this information to the file.

Potential Solution

Update regress.py to take in the path to the last built ERIN bin directory. Also, potentially integrate closer with CTest and ensure that regress.py is only doing things that CTest is not (mainly the regressions). These might be disabled with a flag, for example.

@michael-okeefe michael-okeefe added enhancement New feature or request low-priority "Nice to have" but not necessary; prioritize lower labels May 7, 2024
@michael-okeefe michael-okeefe added this to the 2024 (Year End) milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low-priority "Nice to have" but not necessary; prioritize lower
Projects
None yet
Development

No branches or pull requests

1 participant