Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not using settle in all cases causing unexpected behaviour #22

Open
BJChen990 opened this issue Jul 17, 2020 · 0 comments
Open

Not using settle in all cases causing unexpected behaviour #22

BJChen990 opened this issue Jul 17, 2020 · 0 comments

Comments

@BJChen990
Copy link

transformError(error, reject, config)

settle is not used in the fail handler, causing inconsistent behavior.
The isAxiosError is missing now.

The suggested way to fix this is instead of creating a separate handler as we do in transformError, we create a dummy error response and pass it into the settle function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant