Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow returning None for query interfaces (#255) #256

Conversation

holtgrewe
Copy link
Contributor

No description provided.

@holtgrewe holtgrewe linked an issue Oct 17, 2023 that may be closed by this pull request
@holtgrewe holtgrewe marked this pull request as draft October 17, 2023 13:04
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (dd4eecc) 71.07% compared to head (d9f8938) 70.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
- Coverage   71.07%   70.95%   -0.12%     
==========================================
  Files          60       60              
  Lines        5680     5729      +49     
==========================================
+ Hits         4037     4065      +28     
- Misses       1643     1664      +21     
Files Coverage Δ
src/clinvar_minimal/cli/query.rs 93.91% <77.77%> (+0.16%) ⬆️
src/dbsnp/cli/query.rs 93.20% <77.77%> (+0.17%) ⬆️
src/tsv/cli/query.rs 91.86% <80.00%> (-0.45%) ⬇️
src/freqs/cli/query.rs 91.81% <89.28%> (-2.13%) ⬇️
src/gnomad_mtdna/cli/query.rs 93.24% <66.66%> (-0.51%) ⬇️
src/gnomad_nuclear/cli/query.rs 93.91% <66.66%> (-0.53%) ⬇️
src/helixmtdb/cli/query.rs 93.24% <66.66%> (-0.51%) ⬇️
src/genes/cli/query.rs 0.00% <0.00%> (ø)
src/clinvar_genes/cli/query.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holtgrewe holtgrewe marked this pull request as ready for review October 17, 2023 13:43
@holtgrewe holtgrewe merged commit b4bf349 into main Oct 17, 2023
7 of 9 checks passed
@holtgrewe holtgrewe deleted the 255-make-it-possible-for-query-api-users-to-obtain-no-query-result branch October 17, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible for query API users to obtain no query result
1 participant