Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mehari wrapper vcf preprocessing does not actually fix info svlen header (#450) #451

Merged
merged 2 commits into from
Oct 11, 2023
Merged

fix: mehari wrapper vcf preprocessing does not actually fix info svlen header (#450) #451

merged 2 commits into from
Oct 11, 2023

Conversation

Nicolai-vKuegelgen
Copy link
Contributor

@Nicolai-vKuegelgen Nicolai-vKuegelgen commented Oct 11, 2023 •
edited
Loading

fix: mehari wrapper vcf preprocessing does not actually fix info svlen header (#450)

@Nicolai-vKuegelgen Nicolai-vKuegelgen linked an issue Oct 11, 2023 that may be closed by this pull request
Mehari wrapper vcf preprocessing does not actually fix INFO-SVLEN header #450
Closed
@holtgrewe
Copy link
Member

PR title (and commit message first line if only one commit) should be:

fix|feat|chore: THIS IS THE REAL MESSAGE (#<TICKET IT>)

@coveralls
Copy link

coveralls commented Oct 11, 2023 •
edited
Loading

Coverage Status

coverage: 85.642%. remained the same when pulling 63dd518 on 450-mehari-wrapper-vcf-preprocessing-does-not-actually-fix-info-svlen-header into 46b2303 on main.

holtgrewe
holtgrewe requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@holtgrewe holtgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks good, first line of commit message and PR title need change

@Nicolai-vKuegelgen Nicolai-vKuegelgen changed the title 450 mehari wrapper vcf preprocessing does not actually fix info svlen header fix: mehari wrapper vcf preprocessing does not actually fix info svlen header (#450) Oct 11, 2023
@Nicolai-vKuegelgen Nicolai-vKuegelgen merged commit 55146c7 into main Oct 11, 2023
8 of 9 checks passed
@Nicolai-vKuegelgen Nicolai-vKuegelgen deleted the 450-mehari-wrapper-vcf-preprocessing-does-not-actually-fix-info-svlen-header branch October 11, 2023 13:18
@tedil tedil mentioned this pull request Jun 28, 2024
Merged
This was referenced Dec 9, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holtgrewe holtgrewe holtgrewe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mehari wrapper vcf preprocessing does not actually fix INFO-SVLEN header
3 participants
@Nicolai-vKuegelgen @holtgrewe @coveralls