-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: feature-complete end-to-end run of the Becnel dataset on hs37d5 & GRCh38.d1.vd1 #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a variant in the translation initiation codon
…rather than a wrapper
…ation in the filtration step
The somatic_cnv_checking step now only accepts DNAcopy format for CNV description. The format is only defined in the DNAcopy reference manual (https://bioconductor.org/packages/release/bioc/manuals/DNAcopy/man/DNAcopy.pdf) BREAKING CHANGE: All tools in the somatic_targeted_cnv_calling step must be changed. (see further commits)
…utation & plots), and replacement of BED to DNAcopy CNV format Behaviour changes to purecn pertaining to CNV description format also rolled in. Those changes are in the workflow file and its tests.
…ry_name), and fix for PureCN bug
…e library_name for coverage compatibility
mbenary
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, worked on DKTK-Master as well.
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is feature-complete somatic snappy branch, ready for tagging.
sequenza
&PureCN
CNV calling, required for purity & ploidy, and for homologous recombination deficiency.