fix: remove hard coded contig names from gcnv wrappers (#489 ) #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedil
requested changes
Apr 2, 2024
There was a problem hiding this comment.
As I don't know what the input looks like, the grep patterns might be too unspecific.
Other than that, looks good to me.
(Though I would like to remove code duplication and ideally find a better way of handling this. A dedicated 'give me the prefix'/'give me the sex chromosome names' rule whose output serves as additional input/param for other rules.)
tedil
approved these changes
Apr 8, 2024
Nicolai-vKuegelgen
deleted the
489-gcnv-ploidy_priors-has-hard-coded-contig-names
branch
Nicolai-vKuegelgen
restored the
489-gcnv-ploidy_priors-has-hard-coded-contig-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.