-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: pin dependency version in all wrapper conda env yamls #492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my understanding the 'r' channel should not be used anymore, also some packages use 'r' as a package name instead of r-base.
I don't think "http://conda.cubi.bihealth.org/cubiconda" is reachable from the outside, so relying on that here is a bit unfortunate (no easy way to fix this though, I guess)
snappy_wrappers/wrappers/bed_jaccard_operations/environment.yaml
Outdated
Show resolved
Hide resolved
snappy_wrappers/wrappers/cbioportal/generate_cna/environment.yaml
Outdated
Show resolved
Hide resolved
snappy_wrappers/wrappers/cbioportal/merge_tables/environment.yaml
Outdated
Show resolved
Hide resolved
snappy_wrappers/wrappers/cnvetti/on_target/coverage/environment.yaml
Outdated
Show resolved
Hide resolved
snappy_wrappers/wrappers/signatures/deconstruct_sigs/environment.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
However, this covers many more steps than I am familiar with, so can't guarantee that this won't break anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@Nicolai-vKuegelgen @ericblanc20 as long as the default rerun-triggers are used (which are currently set to |
This PR aims to increase reproducibility and is a precursor to be able to properly end-to-end test the pipeline.
All version specifications in the wrappers' environment.yaml files were pinned to one specific version, in a configuration that can actually be installed with mamba/conda and a strict channel priority (which is why sometimes the channel definitions were also changed).
This was done programmatically, with the exception of some wrappers for which manual intervention was required:
Since there are no tests for the wrappers yet, I can't really be sure if this breaks anything, so I'd rather be cautious and assume that it does.