Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: pin dependency version in all wrapper conda env yamls #492

Merged
merged 12 commits into from
Apr 18, 2024

Conversation

tedil
Copy link
Member

@tedil tedil commented Mar 22, 2024

This PR aims to increase reproducibility and is a precursor to be able to properly end-to-end test the pipeline.
All version specifications in the wrappers' environment.yaml files were pinned to one specific version, in a configuration that can actually be installed with mamba/conda and a strict channel priority (which is why sometimes the channel definitions were also changed).
This was done programmatically, with the exception of some wrappers for which manual intervention was required:

  • gcnv
  • jaffa/run
  • cnvetti/on_target/postprocess
  • svtk
  • scramble
  • link_in_bam
  • lohhla

Since there are no tests for the wrappers yet, I can't really be sure if this breaks anything, so I'd rather be cautious and assume that it does.

@coveralls
Copy link

coveralls commented Mar 22, 2024

Coverage Status

coverage: 85.764%. remained the same
when pulling 7796eed on wrapper-versioning
into e008e7e on main.

Copy link
Contributor

@Nicolai-vKuegelgen Nicolai-vKuegelgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding the 'r' channel should not be used anymore, also some packages use 'r' as a package name instead of r-base.

I don't think "http://conda.cubi.bihealth.org/cubiconda" is reachable from the outside, so relying on that here is a bit unfortunate (no easy way to fix this though, I guess)

snappy_wrappers/wrappers/popdel/environment.yaml Outdated Show resolved Hide resolved
snappy_wrappers/wrappers/rnaqc/dupradar/environment.yaml Outdated Show resolved Hide resolved
snappy_wrappers/wrappers/rnaqc/environment.yaml Outdated Show resolved Hide resolved
snappy_wrappers/wrappers/scalpel/somatic/environment.yaml Outdated Show resolved Hide resolved
@tedil tedil requested a review from Nicolai-vKuegelgen April 9, 2024 13:05
Copy link
Contributor

@Nicolai-vKuegelgen Nicolai-vKuegelgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

However, this covers many more steps than I am familiar with, so can't guarantee that this won't break anything.

@tedil tedil requested a review from ericblanc20 April 16, 2024 12:36
Copy link
Contributor

@ericblanc20 ericblanc20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

snappy_wrappers/wrappers/scarHRD/environment.yaml Outdated Show resolved Hide resolved
snappy_wrappers/wrappers/sequenza/install/environment.yaml Outdated Show resolved Hide resolved
@tedil
Copy link
Member Author

tedil commented Apr 18, 2024

@Nicolai-vKuegelgen @ericblanc20 as long as the default rerun-triggers are used (which are currently set to ["mtime", "params", "input"] I think), this should not trigger re-runs for existing pipelines -- for that, the rerun-trigger software-env would have to be included (or of course all). So I believe this should be safe to merge without impacting any existing projects.

@ericblanc20 ericblanc20 merged commit 79499d9 into main Apr 18, 2024
6 checks passed
@ericblanc20 ericblanc20 deleted the wrapper-versioning branch April 18, 2024 15:43
@github-actions github-actions bot mentioned this pull request Apr 17, 2024
@tedil tedil mentioned this pull request Jun 28, 2024
This was referenced Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants