Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chr format detection in gcnv wrappers needs to always use egrep #529

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix: chr format detection in gcnv wrappers needs to always use egrep #529

merged 2 commits into from
Aug 2, 2024

Conversation

Nicolai-vKuegelgen
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

coverage: 85.8%. remained the same
when pulling 8d9d441 on hotfix-gcnv-wrappers
into 17c1a87 on main.

tedil
tedil requested changes Aug 2, 2024
View reviewed changes
Copy link
Member

@tedil tedil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change

snappy_wrappers/wrappers/gcnv/post_germline_calls_case_mode/wrapper.py Outdated Show resolved Hide resolved
@Nicolai-vKuegelgen @tedil
Update snappy_wrappers/wrappers/gcnv/post_germline_calls_case_mode/wr…
b6e4557 
…apper.py

Co-authored-by: Till Hartmann <till.hartmann@udo.edu>
@coveralls
Copy link

Coverage Status

coverage: 85.778% (-0.02%) from 85.8%
when pulling b6e4557 on hotfix-gcnv-wrappers
into 17c1a87 on main.

tedil
tedil approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@tedil tedil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tedil tedil merged commit ac52a6f into main Aug 2, 2024
6 checks passed
@tedil tedil deleted the hotfix-gcnv-wrappers branch August 2, 2024 14:16
@tedil tedil mentioned this pull request Aug 2, 2024
Closed
@bihealth-bot bihealth-bot mentioned this pull request Aug 13, 2024
Merged
This was referenced Dec 9, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedil tedil tedil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nicolai-vKuegelgen @coveralls @tedil