Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill empty months in timeline chart #897

Closed
mzur opened this issue Jul 26, 2024 · 4 comments · Fixed by #910
Closed

Fill empty months in timeline chart #897

mzur opened this issue Jul 26, 2024 · 4 comments · Fixed by #910
Assignees
Labels

Comments

@mzur
Copy link
Member

mzur commented Jul 26, 2024

#893 changed the x-axis of the timeline chart from years to months. This makes it more likely that there are gaps between months where no annotations were created. These are currently ignored, so there may be non-consecutive months displayed on the x-axis. If a month is empty, fill it in the plot so the x-axis is consecutive again.

@mzur mzur added the bug label Jul 26, 2024
@mzur mzur moved this to Medium Priority in BIIGLE Roadmap Jul 26, 2024
@dlangenk dlangenk self-assigned this Aug 22, 2024
@mzur mzur closed this as completed in #910 Aug 22, 2024
@mzur
Copy link
Member Author

mzur commented Aug 23, 2024

I see an error with the chart on biigle.de. I didn't see this locally. @dlangenk can you investigate?

@mzur mzur reopened this Aug 23, 2024
@dlangenk
Copy link
Member

I also see the error in the live version, but I'm pretty sure it wasn't there locally. I'll have a look.

@dlangenk
Copy link
Member

dlangenk commented Aug 23, 2024

I think I figured out where the error is coming from.... but It should not be there.

This is a line I changed in #893.

I now get this error that t.year is undefined.
image

Is this a different position? But there is no occurence of year.toString in the core repo. I also confirmed that the error is only in the live version. Caching is disabled.

@mzur
Copy link
Member Author

mzur commented Aug 27, 2024

Seems like the error was introduced in #893. Somehow the JS was not up to date in the production version. The issue is resolved with the most recent release.

@mzur mzur closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants