-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill empty months in timeline chart #897
Comments
I see an error with the chart on biigle.de. I didn't see this locally. @dlangenk can you investigate? |
I also see the error in the live version, but I'm pretty sure it wasn't there locally. I'll have a look. |
I think I figured out where the error is coming from.... but It should not be there. This is a line I changed in #893.
I now get this error that t.year is undefined. Is this a different position? But there is no occurence of year.toString in the core repo. I also confirmed that the error is only in the live version. Caching is disabled. |
Seems like the error was introduced in #893. Somehow the JS was not up to date in the production version. The issue is resolved with the most recent release. |
#893 changed the x-axis of the timeline chart from years to months. This makes it more likely that there are gaps between months where no annotations were created. These are currently ignored, so there may be non-consecutive months displayed on the x-axis. If a month is empty, fill it in the plot so the x-axis is consecutive again.
The text was updated successfully, but these errors were encountered: