Merge pull request #84 from biigle/use-assertSame

Replace assertEquals by assertSame

Author: mzur

tests/ImageTest.php

@@ -35,9 +35,9 @@ public function testConvert()
             'attrs' => [Image::LASERPOINTS_ATTRIBUTE => ['area' => 500]],
         ]);
         $laserpointsImage = Image::convert($image);
-        $this->assertEquals($image->id, $laserpointsImage->id);
+        $this->assertSame($image->id, $laserpointsImage->id);
         $this->assertTrue($laserpointsImage instanceof Image);
-        $this->assertEquals(500, $laserpointsImage->laserpoints['area']);
+        $this->assertSame(500, $laserpointsImage->laserpoints['area']);
     }
 
     public function testLaserpoints()
@@ -51,7 +51,7 @@ public function testLaserpoints()
         $expect = [
             'area' => 500,
         ];
-        $this->assertEquals($expect, $image->fresh()->laserpoints);
+        $this->assertSame($expect, $image->fresh()->laserpoints);
     }
 
     public function testAreaAttribute()
@@ -63,15 +63,15 @@ public function testAreaAttribute()
             'area' => 600,
         ];
         $image->save();
-        $this->assertEquals(600, $image->fresh()->area);
+        $this->assertSame(600, $image->fresh()->area);
 
         // Laser point detection overrides the metadata.
         $image->laserpoints = [
             'area' => 500,
         ];
         $image->save();
 
-        $this->assertEquals(500, $image->fresh()->area);
+        $this->assertSame(500, $image->fresh()->area);
     }
 
     public function testLaserpointsNotThere()

tests/Jobs/ProcessDelphiJobTest.php

@@ -53,17 +53,17 @@ public function testHandle()
         with(new ProcessDelphiJob($this->image, 30, $this->gatherFile))->handle();
 
         $expect = [
+            'error' => false,
             'area' => 100,
             'count' => 3,
             'method' => 'delphi',
             'points' => [[100, 100], [200, 200], [300, 300]],
-            'error' => false,
             'distance' => 30,
         ];
 
-        $this->assertEquals($expect, $this->image->fresh()->laserpoints);
+        $this->assertSame($expect, $this->image->fresh()->laserpoints);
         // Previously set attrs should not be lost.
-        $this->assertEquals(1, $this->image->fresh()->attrs['a']);
+        $this->assertSame(1, $this->image->fresh()->attrs['a']);
     }
 
     public function testHandleGracefulError()
@@ -88,7 +88,7 @@ public function testHandleGracefulError()
             'distance' => 30,
         ];
 
-        $this->assertEquals($expect, $this->image->fresh()->laserpoints);
+        $this->assertSame($expect, $this->image->fresh()->laserpoints);
     }
 
     public function testHandleFatalError()
@@ -121,6 +121,6 @@ public function testHandleFatalError()
             'distance' => 30,
         ];
 
-        $this->assertEquals($expect, $this->image->fresh()->laserpoints);
+        $this->assertSame($expect, $this->image->fresh()->laserpoints);
     }
 }

tests/Jobs/ProcessManualJobTest.php

@@ -44,17 +44,16 @@ public function testHandle()
         with(new ProcessManualJob($this->image, $this->points, 30))->handle();
 
         $expect = [
+            'error' => false,
             'area' => 100,
             'count' => 3,
             'method' => 'manual',
             'points' => [[100, 100], [200, 200], [300, 300]],
-            'error' => false,
             'distance' => 30,
         ];
-
-        $this->assertEquals($expect, $this->image->fresh()->laserpoints);
+        $this->assertSame($expect, $this->image->fresh()->laserpoints);
         // Previously set attributes should not be lost.
-        $this->assertEquals(1, $this->image->fresh()->attrs['a']);
+        $this->assertSame(1, $this->image->fresh()->attrs['a']);
     }
 
     public function testHandleGracefulError()
@@ -79,7 +78,7 @@ public function testHandleGracefulError()
             'distance' => 30,
         ];
 
-        $this->assertEquals($expect, $this->image->fresh()->laserpoints);
+        $this->assertSame($expect, $this->image->fresh()->laserpoints);
     }
 
     public function testHandleFatalError()
@@ -112,6 +111,6 @@ public function testHandleFatalError()
             'distance' => 30,
         ];
 
-        $this->assertEquals($expect, $this->image->fresh()->laserpoints);
+        $this->assertSame($expect, $this->image->fresh()->laserpoints);
     }
 }

tests/Jobs/ProcessVolumeDelphiJobTest.php

@@ -43,7 +43,7 @@ public function testHandle()
 
 
         $expect = [$image->id => '[[0,0],[0,0],[0,0]]'];
-        $this->assertEquals($expect, $job->points->toArray());
+        $this->assertSame($expect, $job->points->toArray());
 
         Bus::assertBatched(function (PendingBatch $batch) {
             return $batch->jobs->count() === 1 && $batch->jobs[0] instanceof ProcessDelphiJob;

tests/VolumeTest.php

@@ -16,7 +16,7 @@ public function testConvert()
     {
         $volume = BaseVolumeTest::create();
         $laserpointsVolume = Volume::convert($volume);
-        $this->assertEquals($volume->id, $laserpointsVolume->id);
+        $this->assertSame($volume->id, $laserpointsVolume->id);
         $this->assertTrue($laserpointsVolume instanceof Volume);
     }