Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error with area NaN #35

Closed
mzur opened this issue Sep 20, 2019 · 5 comments · Fixed by #82
Closed

Fatal error with area NaN #35

mzur opened this issue Sep 20, 2019 · 5 comments · Fixed by #82
Assignees
Labels

Comments

@mzur
Copy link
Member

mzur commented Sep 20, 2019

[2019-09-20 10:47:15] production.ERROR: Fatal error with laser point detection (code 0).
{
  "command":"/usr/bin/python /var/www/vendor/biigle/laserpoints/src/config/../resources/scripts/delphi_apply.py '/var/www/storage/framework/cache/laserpoints/biigle_delphi_gather_output_5d849144ea6d1' '/var/www/storage/framework/cache/files/806fb3d29e0e31b86cc5a48b1b799ecf8e12132ae9890ce959f19a9e32e631af' '6.4' 2>&1",
  "output":["{\"count\": 3, \"area\": NaN, \"points\": [[2206.5, 1499.0], [2208.0, 1498.0], [2211.0, 1496.0]], \"method\": \"delphi\", \"error\": false}"]
}

It's curious that the code is 0 and error is false and this is still found in the logs. Check how this is possible. Also check how it could find laser points but couldn't compute the area.

@mzur mzur added the bug label Sep 20, 2019
@mzur
Copy link
Member Author

mzur commented Sep 20, 2019

I couldn't determine which image this was, only that it came from volume 1835.

@mzur
Copy link
Member Author

mzur commented Sep 20, 2019

The error was thrown (despite code 0) because json_decode returns null if there is a NaN in the JSON. I have no idea how a NaN can happen here. It came from the delphi_alpply.py script, which was executed till the end. @dlangenk any ideas?

Edit: Probably from here since there are 3 laser points.

@mzur
Copy link
Member Author

mzur commented Sep 20, 2019

Maybe this line tried to do sqrt with a negative number?

@dlangenk
Copy link
Member

Usually this shouldn't be possible but I'll have a look.

@mzur mzur moved this to Medium Priority in BIIGLE Roadmap Oct 15, 2021
@dlangenk
Copy link
Member

The error is indeed that sqrt that is called with a negative number (although it is practically 0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants