Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startIndex and endIndex have the wrong values for certain indices when max index is too high #2

Open
ronenfe opened this issue Apr 27, 2022 · 2 comments

Comments

@ronenfe
Copy link

ronenfe commented Apr 27, 2022

I have a CircularRangeSlider with max set to 31.

On the event onRangeRelease,onRangeChange, when I set startIndex or endIndex in the ui for the following values: It receives it as the value - 1:
16, 17, 19, 20, 23, 24, 25, 28, those bad indices can change depending on max index. I think it's because the physical distance in the graphic is too small. The thing is the ui shows the selection correctly so I think it's an easy fix.
The maximum working max value is 30. Any max set to above 30 causes this bug.

@ronenfe ronenfe changed the title How do I put this widget in my app? onRangeRelease startIndex has the wrong values for certain indices May 8, 2022
@ronenfe ronenfe changed the title onRangeRelease startIndex has the wrong values for certain indices startIndex and endIndex have the wrong values for certain indices May 8, 2022
@ronenfe ronenfe changed the title startIndex and endIndex have the wrong values for certain indices startIndex and endIndex have the wrong values for certain indices when max index is too high May 8, 2022
@ronenfe
Copy link
Author

ronenfe commented May 28, 2024

Untitled.video.-.Made.with.Clipchamp.mp4

I have made a sample project demonstrating the bug:

https://github.com/ronenfe/CircularSliderBugSample

@ronenfe
Copy link
Author

ronenfe commented May 28, 2024

FIxed, The bug happens when endindex is even.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant