Support for sourcelink

[taori]

Adding sourcelink to the project would greatly benefit the project, because anyone could easily debug it and figure out what exactly is going wrong. Just now i'm having a bug, which would be easily detectable with this :)

I will provide help if you want.

[bilal-fazlani]

I had to disable it last time due to some issues. NuGet/Home#6082
Will enable again for next release

[taori]

I had to disable it last time due to some issues. NuGet/Home#6082
Will enable again for next release

Nice. It's pretty simple to enable now.

You can take a peek at

https://github.com/taori/Amusoft.UI.WPF/blob/master/src/Amusoft.UI.WPF/Amusoft.UI.WPF.csproj

Though in CI i build with DebugType embedded + EmbedAllSources for best sourcelink user experience, so it does not depend on github / internet connection

[bilal-fazlani]

I am hoping this should do it. 16e5d3a + df7a0b2

[taori]

@bilal-fazlani any specific reason you change netcore to 2.2 on the main project? That would limit its usage.

Also you might need to verify whether stepping into code works. appveyor does not support snupkg yet and debugging for snupkg doesnt seem to be working properly yet. That's why i went for DebugType=embedded + EmbedAllSources. That way sourcelink never did any file loading and worked out of the box

[bilal-fazlani]

any specific reason you change netcore to 2.2 on the main project? That would limit its usage.
We are back to 2.1 now

appveyor does not support snupkg yet and debugging for snupkg doesnt seem to be working properly yet. That's why i went for DebugType=embedded + EmbedAllSources. That way sourcelink never did any file loading and worked out of the box

Ok we are back to symbols.nupkg format.

This is how csproj looks like now

<PublishRepositoryUrl>true</PublishRepositoryUrl>
<IncludeSymbols>true</IncludeSymbols>
<EmbedAllSources>true</EmbedAllSources>
<DebugType>embedded</DebugType>
<DebugSymbols>true</DebugSymbols>

https://ci.appveyor.com/project/bilal-fazlani/commanddotnet/build/artifacts

Also you might need to verify whether stepping into code works.

I will do that

[bilal-fazlani]

Question @taori , with this, do I still need to publish a symbols package?

[taori]

@bilal-fazlani with <DebugType>embedded</DebugType> you can make it <IncludeSymbols>false</IncludeSymbols>. IncludeSymbols is the parameter to generate *.symbols.nupkg. However with embedded, the .pdb info is included in the .dll. so you no longer need a .symbols.nupgk :)

That means nuget will only receive one nupkg and debug will be possible at all times.

[bilal-fazlani]

Awesome.