Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire app changed its destination (to wire-desktop). hardcode-tray still assumes it is in wire directory #351

Closed
dwellerattic opened this issue May 9, 2017 · 3 comments
Milestone

Comments

@dwellerattic
Copy link

dwellerattic commented May 9, 2017

Specifications

  • Hardcode-Tray version : ``
  • Distribution : Antegro (Arch Linux) KDE
  • Gtk version : ``
  • Inkscape version : `` if installed
  • Cairo version : `` if installed
  • Sni-qt version: `` if installed
  • Application name : Wire
  • Application version : 2.13.2741-1

Expected behavior and actual behavior

Expected Wire to be found in /usr/lib/wire-desktop
Actual behaviour is an app is sought in /usr/lib/wire

As a side note, asar is now called electron.asar. wire_elec.json in hardcode-tray refers to app.asar

Steps to reproduce the problem

  1. install latest wire-desktop with pacaur -S wire-desktop
  2. apply hardcode-tray to a theme (I did this hardcode-tray -lt Papirus-Light -dt Papirus-Dark -o wire)
  3. hardcode-tray complains with No apps to fix! Please report on GitHub if this is not the case
@bilelmoussaoui
Copy link
Owner

I will take a look this evening :)

@dwellerattic
Copy link
Author

dwellerattic commented May 12, 2017

Very much appreciated. I got it working after patching wire.json and wire_elec.json (I realise I could override it with a local config):

in this way

{
    "name": "Wire",
    "app_path": [
        "/opt/Wire/",
        "/usr/lib/wire-desktop/"
    ],
    "icons_path": [
        "/opt/Wire/resources/app/img/",
        "/usr/lib/wire-desktop/resources/app/img/"
    ],
    "is_qt": false,
    "force_create_folder": false,
    "exec_path_script": false,
    "is_script": false,
    "backup_ignore": false,
    "icons": {
        "tray": {
            "original": "tray.png",
            "theme": "wire-tray"
        },
        "notification": {
            "original": "tray.badge.png",
            "theme": "wire-tray-attention"
        }
    }
}

And I got an icon
image

@bilelmoussaoui
Copy link
Owner

@dwellerattic A PR will be much appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants