Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CODE] Convert Iron Router to Flow Router #127

Open
billimarie opened this issue Oct 4, 2020 · 7 comments
Open

[CODE] Convert Iron Router to Flow Router #127

billimarie opened this issue Oct 4, 2020 · 7 comments

Comments

@billimarie
Copy link
Owner

It looks like Iron Router hasn't been updated since 4 years ago. If there is a way to remove it & add Flow Router instead, that would help numerous bugs--including one where we can't click on the attorney card to view the attorney profile.

@michaelknowles
Copy link

I can take a look at this one

@billimarie
Copy link
Owner Author

Wonderful; I have assigned you this ticket. Feel free to reach out if you come across any issues.

@michaelknowles
Copy link

I've implemented Flow Router. Do you have a list of bugs that I can check to ensure they've been fixed by this change?

@billimarie
Copy link
Owner Author

Hi @michaelknowles, thank you for taking the lead on this. Unfortunately I did not have a chance to update this issue (which was created before this PR: #129). As of now, there are no bugs which we can discern are caused by Iron Router; in your expertise, which router is working best? I have an inkling Flow Router is the better option due to its more recent updates, but I am curious if there's any reason why we should continue to use Iron Router.

@michaelknowles
Copy link

I'm not an expert on Meteor but I don't see a reason to use an abandoned library. Even if we don't have problems now, it's probably good to change before the website gets bigger and more complicated.

@michaelknowles
Copy link

#158

@sumit851
Copy link

plz assign me to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants