[R4R]validator only write database state when enough distance #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoyangLiu
approved these changes
Mar 19, 2021
3 tasks
unclezoro
added a commit
to unclezoro/bsc
that referenced
this pull request
Apr 13, 2021
add consensus engine Parlia implement add async write rotate log handler add precompile light client contracts prepare for release 1.0.0-alpha.0 for Rialto network #1 Signed-off-by: fudongbai <296179868@qq.com> add key features to the readme update 'running a node' part of readme (#2) more strick condition for system transaction add gov init transaction fix validator failed to sync a block produced by itself update stale depth add gas limit check in parlia implement remove redundant gaslimit check fix debug_traceTransaction crashed issue (bnb-chain#13) add bep2p tokens for faucet (#5) add cross chain contract to system contract allow slash failed (bnb-chain#15) update metaversion to beta.0 add changelog for v1.0.0-beta.0 add chain id into sign bytes to avoid replay attack (bnb-chain#18) reestimate the gas consumption for system tx when there is 41 validators (bnb-chain#19) prepare for 1.0.0-beta.1 (bnb-chain#20) resolve best practice advice enforce backoff time for out-turn validator (bnb-chain#23) framework for upgrade system contract improve upgrade config refactor upgrade config add beforeUpgrade and afterUpgrade add multiple upgrade config resolve comment add upgrade height for rialto fix deplay check fix hex code of new smart contract fix index out of range fix not return error when blockTimeVerifyForRamanujanFork failed update chapel ramanujan fork prepare for release 1.0.1-beta add niels fork eth/tracers: revert reason in call_tracer + error for failed internal calls (#21387) * tests: add testdata of call tracer * eth/tracers: return revert reason in call_tracer * eth/tracers: regenerate assets * eth/tracers: add error message even if no exec occurrs, fixes #21438 Co-authored-by: Martin Holst Swende <martin@swende.se> remove disclaim prepare for release 1.0.2 R4R: add max gas allwance calculation (bnb-chain#36) * calculate max gas allwance * return error for missing from prepare release 1.0.3 use fixed gas price since bsc network is idle upgrade to golang1.15.5 Disable noisy log from consensus engine Hide some smart contract tracing logs from parlia consensus engine Create PULL_REQUEST_TEMPLATE add change log for release v1.0.4 add curl in docker image les: fix GetProofsV2 bug (#21896) fix potential deadlock of pub/sub module add rpc method request gauge add x-forward-for message in log support fork id in header; elegant upgrade avoid false warn log consensus/ethash: use 64bit indexes for the DAG generation (#21793) * Bit boundary fix for the DAG generation routine * Fix unnecessary conversion warnings Co-authored-by: Sergey Pavlov <spavlov@gmail.com> signer/storage: fix a badly ordered error check (#21379) core: fix txpool off-by-one error (#21683) internal/ethapi: fix nil deref + fix estimateGas console bindings (#21601) * tried to fix * fix for js api * fix for nil pointer ex * rev space * rev space * input call formatter rpc: fix issue with null JSON-RPC messages (#21497) accounts/abi: fix a bug in getTypeSize method (#21501) * accounts/abi: fix a bug in getTypeSize method e.g. for "Tuple[2]" type, the element of the array is a tuple type and the size of the tuple may not be 32. * accounts/abi: add unit test of getTypeSize method p2p/enode: avoid crashing for invalid IP (#21981) The database panicked for invalid IPs. This is usually no problem because all code paths leading to node DB access verify the IP, but it's dangerous because improper validation can turn this panic into a DoS vulnerability. The quick fix here is to just turn database accesses using invalid IP into a noop. This isn't great, but I'm planning to remove the node DB for discv5 long-term, so it should be fine to have this quick fix for half a year. Fixes #21849 p2p/discover: fix deadlock in discv5 message dispatch (#21858) This fixes a deadlock that could occur when a response packet arrived after a call had already received enough responses and was about to signal completion to the dispatch loop. Co-authored-by: Felix Lange <fjl@twurst.com> R4R: apply mirror sync upgrade (bnb-chain#56) * apply mirror sync upgrade remove 0x update rialto genesis hash update tokenhub code * update tokenhub code * update relayer incentive contract code * update upgrade height and remove mainnet upgrade prepare for release v1.0.5 (bnb-chain#64) [R4R]appay mirror/sync fork to main-net; release for 1.0.6 (bnb-chain#68) * appay mirror/sync fork to main-net; release for 1.0.6 * fix upgrade do not work change the fork waring to debug to avoid confusion (bnb-chain#73) add jq to docker file (bnb-chain#84) add tini for docker image (bnb-chain#90) Co-authored-by: swift.du <yalin.du@binance.com> add directbroadcast flag (bnb-chain#99) limit range get log R4R: add batch query methods (bnb-chain#115) * add batch query method * GetTransactionDataAndReceipt * add new rpc to goclient * fix web3 console * rename tx_data to txData [R4R]apply max commit tx time for miner worker (bnb-chain#112) * apply max commit tx time for miner worker * update to 200 ms validator only write database state when enough distance (bnb-chain#116) add health check endpoint (bnb-chain#120) prepare for release v1.0.7 update receiptsCacheLimit to 10000
vietthang207
pushed a commit
to KyberNetwork/bsc
that referenced
this pull request
May 11, 2021
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the validators of BSC run prune state node, it will write state in period. However, the write operation will take more than 3 seconds, it may get the validator been slashed or the next validator will generate an empty block.
This PR is to fix this without running in archive mode.
Rationale
What we introduce:
The validators are scheduled to generate blocks in order, it is safe to write when the validator still far from its turn to generate blocks.
Example
No
Changes
The condition to write block state. No affect to data-seed
Preflight checks
make build)make test)Already reviewed by
...
Related issues
... reference related issue #'s here ...