[R4R]: resolve best practice advice #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[R4R] Prepare for release v1.0.0-beta.0
unclezoro
changed the title
unclezoro
approved these changes
Aug 5, 2020
yutianwu
approved these changes
Aug 5, 2020
irrun
added a commit
to irrun/bsc
that referenced
this pull request
Apr 26, 2024
* fix: allow fast node to rewind after abnormal shutdown (bnb-chain#2401) (cherry picked from commit fb435eb) * fix: bundlepool concurrent read and write and commit blob tx issue * feat: set MaxBundleAliveBlock as bundle's default ddl --------- Co-authored-by: buddho <galaxystroller@gmail.com> Co-authored-by: irrun <irunert@gmail.com>
redhdx
added a commit
to redhdx/bsc
that referenced
this pull request
May 30, 2024
* builder: implement BEP322 builder-api (bnb-chain#7) * feat: mev-builder * consesus: add a interface to set validator at runtime * core/txpool: add bundlepool to maintain bundle txs * core/type: define bundle * internal/ethapi: add sendBundle, bundlePrice, unregis * ethclient: add SendBundle * miner: add fillTransacitonsAndBundles, add Bidder to sendBid to validators * add README.builder.md --------- Co-authored-by: raina <irunert@gmail.com> * fix: index out of range (bnb-chain#10) * feat: call mev_params before send bid (bnb-chain#12) * fix: NPE and wrong profit (bnb-chain#13) * doc: update README.builder.md (bnb-chain#14) * fix: concurrent map write issue (bnb-chain#15) * fix: wrongly switch sync mode from full sync to snap sync issue (bnb-chain#17) * fix: add missing part when preparing env in `SimulateBundle` (bnb-chain#19) * feat: sendBundle return bundle hash (bnb-chain#20) * fix: some builder issues (bnb-chain#22) * fix: allow fast node to rewind after abnormal shutdown (bnb-chain#2401) (cherry picked from commit fb435eb) * fix: bundlepool concurrent read and write and commit blob tx issue * feat: set MaxBundleAliveBlock as bundle's default ddl --------- Co-authored-by: buddho <galaxystroller@gmail.com> Co-authored-by: irrun <irunert@gmail.com> * fix: typo in `BundlePool.AllBundles` (bnb-chain#24) * feat: add `reconnectLoop` for mev validators (bnb-chain#25) * feat: add `reconnectLoop` for mev validators * fix lint issue * fix review comments * fix review comments * feat: ethclient of bundle (bnb-chain#23) * fix: a nil pointer when query bundle price (bnb-chain#28) * feat: set unrevertible tx hashes when sendBid --------- Co-authored-by: Roshan <48975233+Pythonberg1997@users.noreply.github.com> Co-authored-by: raina <irunert@gmail.com> Co-authored-by: Roshan <luoshen1997@gmail.com> Co-authored-by: buddho <galaxystroller@gmail.com> Co-authored-by: zoro <296179868@qq.com>
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
Jul 31, 2024
This commit squashes the op-geth fork history into a more maintainable diff for rebasing upon upstream geth. reference-optimistic-geth changes (origins of op-geth in early Bedrock development stage): - Deposit TX Type - Enable deposit tx in EVM/tx pool - Change deposit nonce to not be the max nonce - Extend PayloadAttributesV1 with a Transactions field - Force deposits at the start of each L2 block - Fix height check - noTxPool flag, reproduce block in verifier mode without tx pool interference - Fix RPC json marshalling (ref op-geth PR 4) - Deposit txs block height check in block body validation (ref op-geth PR 5) - core: do not try to reinject deposit txs into tx-pool (ref-op-geth PR 6) - deposit source hash field instead of L2 block height and tx index combination - Include invalid deposits, rewind state, but always persist mint (bnb-chain#10) - Provide gas to Call/Create in deposit transactions (bnb-chain#12) - Add docker builds (ref-op-geth PR 16, 17) - Don't panic on deposit transaction signature values or chain ID (ref-op-geth PR 18) - core: Add version to DepositTx (ref-op-geth PR 19) - Enable Geth build/lint/test in CircleCI (ref-op-geth PR 23) - core: Include guaranteed gas in the gas pool (ref-op-geth PR 21) - core: handle base fee, l1 availability fee, tx fee (ref-op-geth PR 27) - fix: deposit tx hash - fix l1 fee cache, rpc, tracing and tx pool - core: remove deposit-tx sub-type (a.k.a. deposit version byte) - eth/catalyst: allow engine user to reorg own chain - miner: restore ability to reorg deep as block builder - params: print Optimism consensus type in banner - core/types: remove unused protected() method, see upstream PR 23376 - core: do not mutate original balance value in tx pool l1 cost adjustment - core: subtract deposit gas from pool, so other txs do not use the same gas. And fail tx processing if deposits reach gas limit - core/types: deposits do not tip, avoid basefee subtraction - Unmeter the L1 Attributes Transaction - miner: handle force tx errors as critical, clean up diff - ci: Switch branch - eth,miner: return STATUS_INVALID when failing to process forced transactions in request (ref-op-geth PR 40) - verifier: forward tx to sequencer based on flag - txpool: add flag to disable tx gossip (ref-op-geth PR 42) - Add op-geth version in addition to geth version (ref-op-geth PR 43) - ci: CircleCI improvements (ref-op-geth PR 44) - Rename to op-geth - Build latest tag on optimism branch op-geth changes: - Expose cache config in simulated backend (bnb-chain#2) - Add EIP-1559 parameters - eth/catalyst: update payload id computation (bnb-chain#1) - make eip1559 configurable (bnb-chain#4) - post-merge network should not log warnings about missing transition information (bnb-chain#5) - Make the simulator more configurable (bnb-chain#6) - fix OPB-6 - IsDepositTx check instead of artificial nonce value check (bnb-chain#7) - Simulated backend - enable proof of stake consensus type and fix performance issue (bnb-chain#8) - accounts: simulated backend consensus engine option and immediate tx indexing - consensus/beacon: recognize all blocks as reached TTD with 0 TTD in chain config - Add --rollup.historicalhttp CLI flag and fix backend iface - Flags and interfaces for historical RPC requests (bnb-chain#12) - Redirect historical RPC requests (bnb-chain#13) - Use the pre-existing ethereum.NotFound error (bnb-chain#18) - Add historical endpoint to TraceBlockByNumber and TraceBlockByHash (bnb-chain#19) - Add historical endpoint to TraceTransaction (bnb-chain#20) - Add historical endpoint to TraceCall (bnb-chain#21) - optimism: fee params from info txi, update l1 cost func GPO params read (bnb-chain#15) - add hardcoded addresses for fee payouts (bnb-chain#23) - dynamic gas limit via engine API (bnb-chain#22) Co-authored-by: Matthew Slipper <me@matthewslipper.com> Co-authored-by: Joshua Gutow <jgutow@oplabs.co> Co-authored-by: protolambda <proto@protolambda.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Maurelian <maurelian@protonmail.ch>
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
Jul 31, 2024
…chain#22) Co-authored-by: Welkin <welkin.b@nodereal.com> Co-authored-by: Owen <103096885+owen-reorg@users.noreply.github.com>
galaio
added a commit
to galaio/bsc
that referenced
this pull request
Aug 16, 2024
* txdag: add excluded flag; mvstates: generate txdag with excluded flag; * pevm: support txdag with excluded tx; * blockchain: opt txdag file mode; * pevm: fix dispatch bugs; * pevm: opt txdag dispatch; --------- Co-authored-by: galaio <galaio@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.