[R4R] fix validator pipecommit issue #877
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a validator runs 1.1.9 with
pipecommit
enabled, sometimes it will fail to write block due to incorrect account roots, like this:This pr fix this issue by calling
CorrectAccountsRoot
before commit the block in mining.Rationale
In
pipecommit
, the account roots are populated with dummy data, in the importing process the account roots are corrected, however, they are not corrected in the mining process. If the miner uses dummy roots to commit block, there will be errors.Example
Fix with this pr, validators can commit block successfully.
Changes
Notable changes: