Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

BinanceApiCallback must have an onFailure() method #58

Closed
antoinebaudoux opened this issue Jan 28, 2018 · 4 comments
Closed

BinanceApiCallback must have an onFailure() method #58

antoinebaudoux opened this issue Jan 28, 2018 · 4 comments

Comments

@antoinebaudoux
Copy link

The BinanceApiAsyncRestClient is useless if the caller of the async method isn't notified in case of error.

The BinanceApiCallback interface must have an onFailure() method so that the caller can be notified of errors.

@joaopsilva
Copy link
Member

Hi @ab-taktik, there's a pull request in #49, which exposes the onFailure method, I will be reviewing it this week and merging it to master. Stay tuned.

@fromjgor
Copy link

Hi @joaopsilvto , great! will be there some example like a cookbook how to implement the error handling properly? Maybe you could also recap the last changes (e.g. related to your recommendation to use singletons instead of creating API instance).
Thanks, @fromjgor

@joaopsilva
Copy link
Member

Hi @ab-taktik , this is now implemented, please update your repository.

@antoinebaudoux
Copy link
Author

@joaopsilva Thank you for the feedback! I'll update

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants