Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Rails 7.1 #768

Closed
morgoth opened this issue Oct 10, 2023 · 5 comments
Closed

Incompatible with Rails 7.1 #768

morgoth opened this issue Oct 10, 2023 · 5 comments

Comments

@morgoth
Copy link
Contributor

morgoth commented Oct 10, 2023

The Rails 7.1 is out, but the authlogic is not compatible with it https://github.com/binarylogic/authlogic/blob/master/authlogic.gemspec#L28-L30

Didn't check if the gem lock is the only blocker.

refs #767

@ansonhoyt
Copy link

@morgoth I think you meant the title to have "Rails 7.1".

@morgoth morgoth changed the title Incompatible with Rails 7 Incompatible with Rails 7.1 Oct 11, 2023
@cedvw
Copy link

cedvw commented Nov 5, 2023

This is trivial and easy to fix issue. PR available. Would be nice to get that merged. Thanks!

@msuliq
Copy link
Contributor

msuliq commented Dec 13, 2023

This issue is still valid as of today. I see that the previous PR is failing in github actions, so I did another PR with minimal changes. I can look into failing CI actions if someone with proper privileges would trigger them

@msuliq
Copy link
Contributor

msuliq commented Dec 13, 2023

For those who are okay with using a fork until the fix is merged upstream, you can add the gem into your Gemfile as:
gem "authlogic", git: "https://github.com/msuliq/authlogic", branch: “bug/compatibility-with-rails-7-1”
This will fetch the fork from my personal repo

@tiegz
Copy link
Contributor

tiegz commented Dec 17, 2023

authlogic 6.4.3 is now published with the Rails 7.1 fixes.

@tiegz tiegz closed this as completed Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants