Web UI: Move the ban reasons to a single place

Author: binarymaster

config.php-distr

@@ -65,6 +65,7 @@ define('USER_TIMEOUT', 24*60*60);
 define('GUEST_WAIT', 10);
 define('INVITE_VALID_FROM_BANNED', false);
 define('ALLOW_BANNED_INVITE_REG', false);
+define('BAN_REASONS', 'guest|parsing|commerce|public|inherit|weak|left');
 
 // Daemons
 define('GEO_PORTION', 100);

index.html

@@ -69,25 +69,10 @@
 }
 function banReasonStr(error)
 {
-	switch (error)
-	{
-		case 'guest':
-		return '%l10n_ban_guest%';
-		case 'parsing':
-		return '%l10n_ban_parsing%';
-		case 'commerce':
-		return '%l10n_ban_commerce%';
-		case 'public':
-		return '%l10n_ban_public%';
-		case 'inherit':
-		return '%l10n_ban_inherit%';
-		case 'weak':
-		return '%l10n_ban_weak%';
-		case 'left':
-		return '%l10n_ban_left%';
-		default:
+	if (error in BanReasons)
+		return BanReasons[error];
+	else
 		return '%l10n_err_unknown%';
-	}
 }
 function encodeHTML(str, spaces)
 {
@@ -368,6 +353,7 @@
 }
 
 var ProfileInfo = {%profile%};
+var BanReasons = %ban_reasons%;
 
 function initmenu()
 {

index.php

@@ -70,7 +70,7 @@ function preparePage(&$content)
 	global $broadcast;
 	$content = str_replace('%broadcast%', $broadcast, $content);
 
-	global $UserManager, $l10n, $profile, $lat, $lon, $rad;
+	global $UserManager, $l10n, $ban_reasons, $profile, $lat, $lon, $rad;
 	$ViewLogin = $UserManager->Login;
 	$ViewNick = $UserManager->Nick;
 	$ViewLevel = $UserManager->Level;
@@ -99,6 +99,7 @@ function preparePage(&$content)
 	if (empty($ViewWAPI)) $ViewWAPI = $l10n['no_access'];
 
 	$content = str_replace('%login_str%', ($UserManager->isLogged() ? $l10n['menu_logout'] : $l10n['menu_login']), $content);
+	$content = str_replace('%ban_reasons%', json_encode($ban_reasons), $content);
 	$content = str_replace('%profile%', $profile, $content);
 	$content = str_replace('%isUser%', (int)$UserManager->isLogged(), $content);
 	$content = str_replace('%login%', htmlspecialchars($ViewLogin), $content);
@@ -203,8 +204,14 @@ function setFloat($in, &$out)
 	}
 }
 
+$ban_reasons = array();
 $profile = 'isUser: %isUser%, Nickname: "%nick%", Level: %user_access_level%, invites: %user_invites%, viewUser: "%view_user%"';
 
+foreach (explode('|', BAN_REASONS) as $reason)
+{
+	$ban_reasons[$reason] = $l10n["ban_$reason"];
+}
+
 $theme_base = 'themes';
 $themes = scandir("$theme_base/");
 $filter = array();

user.html

@@ -93,7 +93,11 @@
 		userBoxTimeout = null;
 		for (var i = -2; i <= 3; i++)
 			$('select#user_level').append($('<option>').val(i).text(levelToText(i)));
-		var br = ['', 'guest', 'parsing', 'commerce', 'public', 'inherit', 'weak', 'left'];
+		var br = [''];
+		for (var reason in BanReasons)
+		{
+			br.push(reason);
+		};
 		br.forEach(function(reason)
 		{
 			$('select#ban_reason').append($('<option>').val(reason).text(reason));