Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/Replace imgui-sfml CMakeLists.txt #1443

Open
TheFloatingBrain opened this issue Jun 9, 2022 · 1 comment
Open

Patch/Replace imgui-sfml CMakeLists.txt #1443

TheFloatingBrain opened this issue Jun 9, 2022 · 1 comment

Comments

@TheFloatingBrain
Copy link

TheFloatingBrain commented Jun 9, 2022

The imgui-sfml CMakeLists.txt file is rather "wonky", I understand that it is nice to have choices, such as using system dependencies (can conan do this automatically) however despite having all of its dependencies available through conan it cant build without downloading the imgui repository even if all such dependencies are installed and specified in requirements due to its cmake file.

Trying to modify its conanfile.py myself (I thought it was not building) getting these options right to make it build in a /build directory is tricky (true once it is successfully installed, there is no need, but this is meant to demonstrate the the issue with the CMakeLists.txt file)

Should its CMakeLists.txt be patched/replaced?

@Gryfenfer97
Copy link
Contributor

The fact that the receipe can't be build without imgui is a problem but doesn't it comes from the conanfile.py file ?
Actually I don't see the problem with the CMakeLists.txt file (or can you explain what the problem is ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants