Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion Request: SPIRV-Headers #744

Closed
12 tasks done
mmha opened this issue Apr 25, 2019 · 1 comment
Closed
12 tasks done

Inclusion Request: SPIRV-Headers #744

mmha opened this issue Apr 25, 2019 · 1 comment
Assignees
Labels
packaging Plans to create a package within Bincrafters

Comments

@mmha
Copy link

mmha commented Apr 25, 2019

Package Details

Inclusion request

  • Fill all checkboxes with x if you agree with the statement or if it applies to your Conan recipe
  • I want that my Conan recipe is getting included into the Bincrafters organisation
  • I understand that if my request is accepted we are cloning your repository with all its history into Bincrafters, adapt some configurations and meta data if needed, and publishing it under the Bincrafters name and accounts
  • I have used the Bincrafters templates to develop my Conan recipe - https://github.com/bincrafters/conan-templates
  • My Conan recipe and all parts of it are licensed under the MIT license - https://choosealicense.com/licenses/mit/
    • Bincrafters are releasing all recipes under MIT license. If you want to have your recipe within Bincrafters we kindly ask you to do the same
    • it is okay if your test_package contains code from the upstream project under the upstream project's license, as long as it is clearly mentioned within the test_package files
  • My Conan recipe covers (at least) the latest stable version which is available for the package
  • I know that my Conan recipe is working on all operating system and compilers mentioned above right now
  • I'm willing to help to maintain the recipe even after it is included into Bincrafters

Notes

Checklist for the Bincrafters team

  • Ignore this if you are not part of the Bincrafters team
  • There is no such Conan package yet in conan-center, conan-community or Bincrafters
  • The project is either popular or deserves to be maintained for another good reason (we can't package every single project out there)
  • bincrafters-conventions reports no complains; the recipe fulfills our general quality requirements and conventions
  • The recipe is cloned into our organisation; CI is enabled and configurated and succeeds
  • There is a branch protection rule for stable/* branches, which requires a pull request with at least one approval first before things can get published
  • Considering granding the inclusion request author push rights to the recipe repository (there is no guarantee that everyone is getting push rights, we decide this on a case-to-case base)
@mmha mmha added the packaging Plans to create a package within Bincrafters label Apr 25, 2019
@Croydon Croydon self-assigned this May 27, 2019
@Croydon
Copy link
Member

Croydon commented May 27, 2019

The recipe is now live at https://github.com/bincrafters/conan-spirv-headers

Please note for further submissions:

  • You didn't choose the right templates. Since this is a header_only recipe you should have used the header_only templates, instead you used the default ones
  • in the readme you need to manually replace package_name with the actual name

Thanks!

@Croydon Croydon closed this as completed May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Plans to create a package within Bincrafters
Projects
None yet
Development

No branches or pull requests

2 participants