Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary "!" escape #610

Closed
asharma0703 opened this issue Jul 16, 2022 · 2 comments
Closed

Unnecessary "!" escape #610

asharma0703 opened this issue Jul 16, 2022 · 2 comments

Comments

@asharma0703
Copy link 

$ bash -c 'echo "!"'
!
$ ./pa.sh -c 'echo "!"'
\!

Removing "!" from chars_to_escape in ast2shell.py fixes it and passes interface tests, but not sure if that's actually safe/valid beyond existing tests.
@angelhof
Copy link
Member

Thanks! I think this is solved in future (soon to be merged on main) with PR #574

@angelhof
Copy link
Member

Also merged this to main now! Closing this issue but feel free to reopen if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asharma0703 @angelhof