Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web app build / dev tooling - Vite, prettier, eslint? #744

Closed
nimbleghost opened this issue May 23, 2023 · 4 comments
Closed

Web app build / dev tooling - Vite, prettier, eslint? #744

nimbleghost opened this issue May 23, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@nimbleghost
Copy link
Contributor

💡 Idea

I'd like to try tackling #199 / #346, but would like to make some development / build improvements first if they sound good to you.

I would switch to Vite to make https testing easier for notifications (and though not deprecated, CRA isn't recommended anymore anyway), plus would add eslint and prettier for static analysis and formatting.

💻 Target components

web app

@nimbleghost nimbleghost added the enhancement New feature or request label May 23, 2023
@binwiederhier
Copy link
Owner

Those all sound like awesome things! Amazing!

I am happy to chat on Discord/Matrix about details if you like, and I ask that you try to do small-ish PRs if possible, and that you discuss the design beforehand if there are many changes.

As for Web Push, I don't fully understand what that means server-side, so maybe you'll have to enlighten me.

@nimbleghost
Copy link
Contributor Author

Sounds great! I will comment on the web push issue once I get to it.

r.e. Discord/Matrix yes - will take a look later.

@binwiederhier
Copy link
Owner

Sounds great! I will comment on the web push issue once I get to it.

It is worth noting that the PWA has been attempted before, so maybe check that code too when you get there.

@nimbleghost
Copy link
Contributor Author

Resolved by #747, #748, #749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants