Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need better error message for hash-based identifiers #34

Open
jdeck88 opened this issue Jun 24, 2020 · 0 comments
Open

Need better error message for hash-based identifiers #34

jdeck88 opened this issue Jun 24, 2020 · 0 comments
Assignees

Comments

@jdeck88
Copy link
Member

jdeck88 commented Jun 24, 2020

When a spreadsheet is loaded and a hash-based ID is duplicated, the resulting message can be confusing to user. E.g. a spreadsheet for amphibian disease with a duplicate materialSampleID and duplicate diagnostic data will return with a message like:

"diagnosticID" column is defined as unique but some values used more than once: "d23e4f1868753a14c82ec1ddcd778ba7"

I guess we can keep the above message in this case but it would be better to provide some more information like:

"diagnosticID" column is defined as unique but some values used more than once: "d23e4f1868753a14c82ec1ddcd778ba7".  If this column is a hashed-based identifier,
check for duplicate rows.

Another, perhaps, better approach is on the unique value check, see if its a hashed-based identifier and if so, provide an alternate message, like:

Duplicate data in entity "Diagnostics" with the same parent ID.  See materialSampleID = 1603000533

bd-duplicaterecordexample.xlsx

@jdeck88 jdeck88 self-assigned this Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant