Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample records removed which have no matching eventIDs #59

Open
jdeck88 opened this issue Aug 25, 2021 · 0 comments
Open

Sample records removed which have no matching eventIDs #59

jdeck88 opened this issue Aug 25, 2021 · 0 comments

Comments

@jdeck88
Copy link
Member

jdeck88 commented Aug 25, 2021

In cases where multiple sheets are present on a data load (e.g. Biocode Team) and for which the data is FIRST loaded using events and samples, and then SECOND reloaded with the "Replace Expedition data" box checked-- with some parent identifiers removed, the invalidParentIdentifier Rule check does not work as expected...

For example: load EventID = 1 and EventID =2 (with associated samples)
Then remove EventID = 2 -- any materialSamples referencing that EventID will be silently dropped.

A workaround for now, is to first check the box "only validate data" BEFORE replacing expedition data.. This will catch the error. (also, i have added a message about this in the data validation and loading page on the UI)

The issue here is that when replacing the expedition data it also references existing parent/child entities in the database during the validation step that may not be present in the workbook-- this is very important in cases where we link photos/fastq data, for example, that we do not want to drop. In the current case, the Events tab IS in the loaded file and we need to write an exception to NOT look in the database for entities that are present in the workbook itself. I think we need to look in the DatasetController class to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant