Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unblacklist rust recipes #9266

Closed
dlaehnemann opened this issue Jun 11, 2018 · 4 comments
Closed

unblacklist rust recipes #9266

dlaehnemann opened this issue Jun 11, 2018 · 4 comments

Comments

@dlaehnemann
Copy link
Member

This is a tracking issue for progress with unblacklisting the two remaining rust recipes in the build blacklist in issue #7712, I.e. these lines (plus rust-bio-tools, which should probably need another look, as well, and spalter and prosolo can probably do with the same simultaneous changes):

# warning: spurious network error (1 tries remaining): [12/-2] [77] Problem with the SSL CA cert (path? access rights?) (error setting certificate verify locations:
recipes/rust-overlaps
recipes/prosic

The remaining issue boils down to some problem with the combination of conda build version 2. and the rust compiler cargo, so the easiest is probably to just wait for the coming bioconda-utils update to 3.x conda build:
bioconda/bioconda-utils#293

The below infos are to document the previous attempt, but hopefully most of these workarounds will not be necessary any more. There is a branch I created with some attempts at getting these recipes unblacklisted, but it should probably be retired in favor of a clean new branch and should only cherry-pick relevant commits, if any:
https://github.com/bioconda/bioconda-recipes/tree/unblacklist_rust_recipes

The commits there incorporate the workarounds identified when unblacklisting prosolo (#7973) and further recommendations given for the new recipe for spalter that's on the way (#9062). But none of these got all the way and eventually we end up with an awkward interaction between the older version of conda build currently used (2.1.18) and cargo's checking that certain paths are absolute paths:

thread 'main' panicked at 'assertion failed: src_path.is_absolute()', tools/cargo/src/cargo/core/manifest.rs:438:9

It goes away when I locally use conda build version 3.4.2, hence the above suggestions to wait for the bioconda-utils update.

It does not go away when using older cargo versions, but the next future rust/cargo version (1.27) should include a change that would at least give a more informative panic message, should more debugging be needed in the future:
rust-lang/cargo@dfdb9aa

@bgruening
Copy link
Member

@dlaehnemann any updates on this one?

@dlaehnemann
Copy link
Member Author

Thanks for the reminder, I'll try to have a look in the coming days!

@dlaehnemann
Copy link
Member Author

rust-overlaps was already fixed by @luizirber in PR #9670 where he references this issue.

prosic has been superseded by varlociraptor. But I would say a final unblacklisted, building version of prosic would be nice, and @luizirber also suggested a way forward by just tagging a newer working version and releasing a it with the bug fix version number increased:

@johanneskoester: Would this still be an option? Just releasing a prosic2 2.1.1?

@dlaehnemann
Copy link
Member Author

There now is a merged prosic2 2.1.2 and prosic is unblacklisted. See PR #18197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants