Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in constant #7

Open
slobentanzer opened this issue Jan 30, 2024 · 6 comments
Open

Typo in constant #7

slobentanzer opened this issue Jan 30, 2024 · 6 comments
Assignees

Comments

@slobentanzer
Copy link
Contributor

ERROR_UNKNOW = 5000

@fengsh27 same questions here, is the typo problematic, and does the constant need to be the same as the port (i.e., do we need to update this to 5001)?

@fengsh27
Copy link
Collaborator

fengsh27 commented Feb 6, 2024

No, this code is just error code and not used as port.

@slobentanzer
Copy link
Contributor Author

OK, thanks for clarifying. Would probably be good to fix the typo.

Is the 5000 code a convention, or is this randomly selected?

@fengsh27
Copy link
Collaborator

fengsh27 commented Feb 6, 2024

I will fix it in next submission. 5000 is random selection : )

@slobentanzer
Copy link
Contributor Author

Hi @fengsh27, this is still unfixed, could be good to do on the side in one of the next feature additions.

@slobentanzer
Copy link
Contributor Author

@fengsh27 reminder that we could get rid of these minor TODOs in the next update

@slobentanzer
Copy link
Contributor Author

@fengsh27 is this fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants