Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta-issue: Website design #58

Closed
constantinpape opened this issue Jul 7, 2020 · 3 comments
Closed

Meta-issue: Website design #58

constantinpape opened this issue Jul 7, 2020 · 3 comments
Labels
website Issues about the website UI

Comments

@constantinpape
Copy link
Contributor

We had a discussion on the design / layout of the bioimage.io website with @vzinche @m-novikov and @akreshuk today.
Most of this was based on feedback @vzinche got from running a ZIDAS image analysis course and getting feedback from the course participants.
See Issues #57 #54 #55 #56 for detailed issues.

Two more observations:

  • Clicking the "Community Partner" icons doesn't work properly, e.g. models are not listed for ilastik and fiji
  • The message displayed when clicking "Share" is not very helpful; it should at least have the url in the message, and at some point should even link to twitter etc.

It's probably a good idea to set discussion of this on the agenda for the call on Friday, see #28.
Unfortunately I can't make it, but @akreshuk will be there from our side.

@constantinpape constantinpape added the website Issues about the website UI label Jul 7, 2020
@oeway
Copy link
Collaborator

oeway commented Jul 7, 2020

Thanks for these suggestions, I tried to explain for some of them.

For the community partner issue, I just investigate a bit, it's basically because non of the ilastik/fiji model has the ilastik or fiji tag applied. Those buttons works by applying a tag filter when you click, so please make sure you explicitly set a ilastik tag for ilastik models.

The share button has been improved in #59 , a preview version here: https://deploy-preview-59--bioimage.netlify.app/

Sounds good, thanks for all these, we can discuss them over the meeting.

@constantinpape
Copy link
Contributor Author

For the community partner issue, I just investigate a bit, it's basically because non of the ilastik/fiji model has the ilastik or fiji tag applied. Those buttons works by applying a tag filter when you click, so please make sure you explicitly set a ilastik tag for ilastik models.

Ok, thanks. We can fix it for the ilastik models.

The share button has been improved in #59 , a preview version here: https://deploy-preview-59--bioimage.netlify.app/

Looks good. (I think eventually we would want "Copy to clipboard" and "Share via twitter", but for now this is totally fine!)

@oeway
Copy link
Collaborator

oeway commented Jul 7, 2020

Looks good. (I think eventually we would want "Copy to clipboard" and "Share via twitter", but for now this is totally fine!)

Sure, we will have those social buttons one day ;)

Ok, thanks. We can fix it for the ilastik models.

BTW, @constantinpape I think it's better for you(Ilastik) to host your own manifest.bioimage.io.yaml file under one of your ilastik/tiktorch repo. Like that you can manage you own repo, no need to send PR to the central model repo when you want to add models. See the deepImageJ example, and this is how we connect it to the central model zoo as a collection. Meanwhile, you can also add or adopt this CI file for run tests in your repo when you add new models.

If you do that, the latest compilation script will apply the ilastik tag automatically for all the models in your repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Issues about the website UI
Projects
None yet
Development

No branches or pull requests

3 participants