Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Domain resets when reopening orange #6414

Closed
janezd opened this issue Apr 14, 2023 Discussed in #6412 · 6 comments · Fixed by #6415
Closed

Edit Domain resets when reopening orange #6414

janezd opened this issue Apr 14, 2023 Discussed in #6412 · 6 comments · Fixed by #6415
Assignees

Comments

@janezd
Copy link
Contributor

janezd commented Apr 14, 2023

Discussed in #6412

Originally posted by zikook April 14, 2023
Hi,
When I close and reopen Orange, changes I've made in Edit Domain, for example naming a variable, sometimes disappear.
This happens when I use the widget 'Create Table' from the Educational tab to send it a table.
I can upload a workflow if it helps.
Anyone experienced this? Is there a workaround?
Thanks,
-Aaron

@janezd
Copy link
Contributor Author

janezd commented Apr 14, 2023

@zikook, thanks. You can upload the workflow (please do), but I'm pretty sure what I'll find there. And it's a bit complicated to explain.

Note to self (or anybody): this widget shouldn't have context settings but a rather permanent-ish storage of "variable hints".

"Permanent-ish": not storing more than 1000 variables or something, so they're not kept indefinitely. LRU.

@AOSTern
Copy link

AOSTern commented Nov 27, 2023

HI, I am working with version 3.36.1 on a windows enviroment and Edit Domain forgot my settings. I had already renamed over 100 values (complex names and categories). This was quite frustrating. It was even more frustrating to find out that it was supposed to have been fixed already.

The work flow goes from import CSV to Edit Domain to Table.

I think the issue arrived when I disconnected the flow of data to the Edit Domain item and then reconnected it again.

I tried to open a previous version of the Edit Domain in a file that i had saved as backup and foud that that Edit Domain had also forgotten the changes.

Thank you in advance for looking into this again.

@markotoplak
Copy link
Member

Something like this should not happen in 3.36 anymore. Are you absolutely sure that the reconnected file had all edited variables (with the same names and types)?

@markotoplak markotoplak reopened this Nov 28, 2023
@AOSTern
Copy link

AOSTern commented Nov 28, 2023

For this particular project, I use just one master csv file that never gets any editing done on it and it just reconects with the flow upon opening the workflow. At one point all the data on the Edit Domain just went blank. I am trying to recall all previous steps to the earasure and there might have been a connection of a formula box that created a new (undesirable) variable (downstream) (undesirable because it had remained on the list from earlier use). I created the desired variable in the formula box and then tried to use an additional Edit Domain box (independently created) to change the domain of the newly created variable (I know it sounds overtly complicated but I am mostly just taking advantage of the high flexibility of conectors and stuff). Anyways at some point that did not work and I disconnected the formula boxes and the new Edit Domain boxes (which I had just created). At that point I reconnected everything back and noticed that I had lost all the original changes in the domain box I had not touched, the one that connects with the CSV directly. After that I reopened and earlier copy (backup) of the workflow only to find out that that Edit Domain had also lost its features.

I hope this helps you to diagnose the problem.

At the moment I have redone all the Edit Domain stuff but have not closed the file (as I don't want to lose all the info again). As soon as I finish gathering all the info from the project (the final analysis) and can close the file again I will try to reproduce the failure to better document it. Thank you again for your attention to this.

@markotoplak
Copy link
Member

I tried replicating your problems by renaming variables and changing types, and could not get anything like you observed.

Could you answer some questions that would help me debug, please? How many variables did you edit in the edit domain (approximately)? What is the type of variable you were working with? Numeric or categorical? If categorical, how many values do your variables have?

I suspect your problem has something to do with matching categorical features. Maybe values didn't match in different data versions, thus the settings seemed lost.

@markotoplak
Copy link
Member

@AOSTern, I found the likely problem. Closed in favor of #6660.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants