[ENH] Parameter Fitter: more responsive when changing settings #7027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callbacks (and thus interruptions) also go into CV.
markotoplak
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7027 +/- ##
==========================================
+ Coverage 88.36% 88.70% +0.33%
==========================================
Files 332 332
Lines 73345 73362 +17
==========================================
+ Hits 64814 65075 +261
+ Misses 8531 8287 -244 |
VesnaT
reviewed
Feb 21, 2025
| @@ -68,7 +75,8 @@ def _search( | |||
| progress_callback(i / len(steps)) | |||
There was a problem hiding this comment.
This line could now be removed.
VesnaT
approved these changes
Feb 21, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callbacks (and thus interruptions) also go into CV.
I was checking why are Parameter Fitter tests so slow. This does not change much for slow tests, but does improve the responsiveness of setting changes with slow learners a lot.
I then added a commit that tries making tests run faster and thus not timeout on Actions. Mainly by actively cancelling running computations when results are not needs.
Includes