Hierarhical Clustering: Narrower combos #7040
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7040 +/- ##
=======================================
Coverage 88.70% 88.70%
=======================================
Files 332 332
Lines 73363 73366 +3
=======================================
+ Hits 65074 65081 +7
+ Misses 8289 8285 -4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #7035.
Description of changes
The current change resolves the problem with the combo for colors, but not for annotation, which uses our own combo with reimplemented showPopup. showPopup is copied from Qt, but apparently without the code at https://github.com/radekp/qt/blob/master/src/gui/widgets/qcombobox.cpp#L2380.
Includes