-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support a variety of non-gene sequence features using 'type' and a generic parent class #1210
Comments
@sierra-moxon What about: http://www.sequenceontology.org/browser/current_release/term/SO:0005836 This would be a Class that uses biolink:GenomicEntity as a mixin. |
There is also: http://www.sequenceontology.org/browser/current_release/term/SO:0002331 (accessible_dna_region) tf_binding_site ISA http://www.sequenceontology.org/browser/current_release/term/SO:0000235 which ISA regulatory_region (SO:0005836) accessible_dna_region ISA epigenically_modified_region (this seems wrong btw) which ISA regulatory_region (SO:0005836) Do you think when modeling a KG like this it's better to use the more general parent (so "all" items are findable without closure) or use the most specific version and rely on the ontology graph to connect. |
if we just use BioCypher to implicitly subclass BiologicalEntity? Then I wouldn't have to actually submit a PR for this ticket... |
@sierra-moxon does my comment make any sense? |
It does, but if you extend in BioCypher, it's a precursor to a PR in Biolink right? What if you just used the biolink class, 'biolink:NucleicAcidEntity' and add the node property, 'biolink:type' to hold a more specific SOTerm of your choosing for each more specific sequence feature that you need (this was @cmungall's original idea)? I took another look at 'biolink:GenomicEntity' and I hesitate to move it to a class vs. a mixin because it is the way we currently bridge the biology/chemistry perceptions of gene as a biological entity vs. a chemical entity (it's both). But I'm willing to explore options here if 'biolink:NucleicAcidEntity' does not make sense.
right - I think you could handle the predictive nature of this with evidence and provenance properties. |
your subject and object nodes might look something like this:
your edge might look like this (these would all be edge properties between the chromosome, or whatever reference sequence you wanted to locate the NucleicAcidEntity on, and the NucleicAcidEntity itself) :
I think we could add an edge property to represent the predictive nature of some of these locations - we've been discussing adding "prediction" or "statistical correlation" or "hypothesis" keywords as evidence types to further qualify an edge. |
` regulatory region: accessible dna region: transcription factor binding site: Not sure if I should make a PR to biocypher instead? |
@hitz - would you consider these new classes to be children of NucleicAcidEntity as well? |
@sierra-moxon I think I would but Gene class isn't? That seems like a mistake. |
from @hitz
What are your thoughts on Objects like:
A “putative cis-regulatory element” defined by a consensus chromatin accessibility peak with or without supporting histone mark data"
Or
“An segment of human genome DNA tested in an MPRA experiment to determine it’s effect on gene expression”
Or
“A region targeted by guide RNAs using a CRISPr activation screen”
I suspect we would have to make some extension for biolink:GenomicEntity to cover non-Gene features.
And in addition, if we want to use biolink:GenomicEntity directly, we need to figure out how to move it out of the mixin hierarchy.
The text was updated successfully, but these errors were encountered: