Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "singular_name" metadata from slots as it causes confusion with TRAPI #1268

Closed
sierra-moxon opened this issue Apr 5, 2023 · 2 comments

Comments

@sierra-moxon
Copy link
Member

a TRAPI message should fail validation if it uses: "biolink:publication" instead of "biolink:publications". In Biolink, the publications slot/attribute has a 'singular_name' field that confuses this validation:

  publications:
    aliases: ["supporting publications"]
    singular_name: publication
    description: >-
      One or more publications that report the statement expressed in an Association, or provide information used as 
      evidence supporting this statement.
    is_a: supporting documents
    multivalued: true
    range: publication

We use this metadata tag very sparingly in Biolink at the moment, only on "authors", "publications", and "qualifiers". As "qualifiers" (as a multivalued slot) is being deprecated, and this issue was raised for "publications", it makes sense to remove this for "authors" as well.

@nlharris
Copy link
Contributor

nlharris commented Apr 6, 2023

@sierra-moxon I have no idea what label to put on this!

@sierra-moxon
Copy link
Member Author

Its ok! :) Its done now. :)
#1269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants