Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map STY:T167 to biolink:ChemicalEntity #1370

Closed
gaurav opened this issue Aug 1, 2023 · 3 comments
Closed

Map STY:T167 to biolink:ChemicalEntity #1370

gaurav opened this issue Aug 1, 2023 · 3 comments
Labels

Comments

@gaurav
Copy link
Contributor

gaurav commented Aug 1, 2023

Is your feature request related to a problem? Please describe.
Some UMLS terms are missing from the NCATS Translator Node Normalization tool (NCATSTranslator/Feedback#425) because they are classified as semantic type T167 "Substance", which does not have a mapping in the Biolink model. It looks like STY:T167 was previously mapped to biolink:ChemicalEntity, but this appears to have been removed at some point. We could include a mapping in Babel (as we've done for previous UMLS STYs, leaving only these identifiers: TranslatorSRI/NodeNormalization#119 (comment)), but it would be better if we could map this semantic type directly in the Biolink model.

Describe the solution you'd like
Add STY:T167 as a mapping for a Biolink class, likely either biolink:ChemicalEntity or biolink:ChemicalMixture.

What working group (or team) did this request originate from?
Translator SRI via NCATSTranslator/Feedback#425

Additional context
Add any other context about the problem here.

Tag relevant members for discussion
@cbizon @sierra-moxon

@gaurav
Copy link
Contributor Author

gaurav commented Sep 30, 2023

@sierra-moxon Any thoughts on this issue?

@gaurav
Copy link
Contributor Author

gaurav commented Oct 20, 2023

I took another look at STY:T167 in the UMLS Semantic Network Browser and -- given that it has child concepts of "food", "chemical" and "body substance" (i.e. "saliva, dental enamel, sweat, and gastric acid", etc) -- I think biolink:ChemicalEntity would be the correct mapping. I've updated the title of this issue to reflect this.

@gaurav gaurav changed the title Map STY:T167 to either biolink:ChemicalEntity or biolink:ChemicalMixture Map STY:T167 to either biolink:ChemicalEntity Oct 20, 2023
@gaurav gaurav changed the title Map STY:T167 to either biolink:ChemicalEntity Map STY:T167 to biolink:ChemicalEntity Oct 20, 2023
@sierra-moxon
Copy link
Member

sounds great! added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants