Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 The import sorter remove unused imports. #345

Open
1 of 3 tasks
cjg1122 opened this issue Sep 13, 2024 · 1 comment
Open
1 of 3 tasks

🐛 The import sorter remove unused imports. #345

cjg1122 opened this issue Sep 13, 2024 · 1 comment
Labels

Comments

@cjg1122
Copy link

cjg1122 commented Sep 13, 2024

VS Code version

1.93.1

Extension version

2.3.0

Biome version

1.9.0

Operating system

  • Windows
  • macOS
  • Linux

Description

The documentation mentions The import sorter doesn’t remove unused imports. We provide the linter rule noUnusedImports with a safe fix that removes unused imports.

as a matter of fact The import sorter remove unused imports.

Steps to reproduce

 "editor.codeActionsOnSave": {
    "quickfix.biome": "explicit",
    "source.organizeImports": "explicit"
  },

cmd+s

Expected behavior

Consistent with documentation or configurable

Does this issue occur when using the CLI directly?

Not applicable

Link to a minimal reproduction

No response

Logs

No response

@cjg1122 cjg1122 added the Triage label Sep 13, 2024
@nhedger nhedger added the Needs reproduction Needs a reproduction label Sep 13, 2024
@cjg1122
Copy link
Author

cjg1122 commented Sep 14, 2024

@nhedger
When I cli the pnpm check import a from ‘. /a" wasn't deleted, but it was deleted when I saved it with cmd +s.

112_1726281450_raw.mp4

@nhedger nhedger added the Stable label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants