Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension fails to activate when there are no workspace folders open #95

Closed
DanTup opened this issue Jan 27, 2024 · 2 comments · Fixed by #98
Closed

Extension fails to activate when there are no workspace folders open #95

DanTup opened this issue Jan 27, 2024 · 2 comments · Fixed by #98
Assignees
Labels
Bug confirmed Report has been confirmed as a valid bug

Comments

@DanTup
Copy link

DanTup commented Jan 27, 2024

If you open VS Code without any workspace folders (for example click File -> Close Folder) and then do anything that triggers the Biome extension to be activated (for example open a .ts file), the extension fails to activate with:

Activating extension 'biomejs.biome' failed: import_vscode6.workspace.workspaceFolders is not iterable.

Possibly caused by this code not handling undefined?

for (const workspaceFolder of workspace.workspaceFolders) {

@nhedger
Copy link
Member

nhedger commented Jan 27, 2024

Thanks for reporting @DanTup!

This should be an easy fix. I'll see what I can do.

@nhedger nhedger added the Bug confirmed Report has been confirmed as a valid bug label Jan 27, 2024
@nhedger nhedger self-assigned this Jan 27, 2024
@DanTup
Copy link
Author

DanTup commented Jan 27, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug confirmed Report has been confirmed as a valid bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants