🐛 noLabelWithoutControl false positives when labels are expressions

[wojtekmaj]

Environment information

CLI:
  Version:                      1.9.0
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v22.7.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "yarn/4.3.1"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

https://biomejs.dev/playground/?code=YwBvAG4AcwB0ACAAbABhAGIAZQBsACAAPQAgACIAVABoAGkAcwAgAGkAcwAgAG4AbwB0ACAAbwBrAGEAeQAiADsACgAKADwAPgAKACAAIAA8AGkAbgBwAHUAdAAgAGkAZAA9ACIAbwBuAGUAIgAgAC8APgAKACAAIAB7AC8AKgAgAFUAbgBkAGUAcgBzAHQAYQBuAGQAYQBiAGwAeQAgAG4AbwB0ACAAbwBrAGEAeQAgACoALwB9AAoAIAAgADwAbABhAGIAZQBsACAAaAB0AG0AbABGAG8AcgA9ACIAbwBuAGUAIgA%2BADwALwBsAGEAYgBlAGwAPgAKACAAIAAKACAAIAA8AGkAbgBwAHUAdAAgAGkAZAA9ACIAdAB3AG8AIgAgAC8APgAKACAAIAA8AGwAYQBiAGUAbAAgAGgAdABtAGwARgBvAHIAPQAiAHQAdwBvACIAPgBUAGgAaQBzACAAaQBzACAAbwBrAGEAeQA8AC8AbABhAGIAZQBsAD4ACgAgACAACgAgACAAPABpAG4AcAB1AHQAIABpAGQAPQAiAHQAaAByAGUAZQAiACAALwA%2BAAoAIAAgADwAbABhAGIAZQBsACAAaAB0AG0AbABGAG8AcgA9ACIAdABoAHIAZQBlACIAPgB7AGwAYQBiAGUAbAB9ADwALwBsAGEAYgBlAGwAPgAKACAAIAAKACAAIAA8AGkAbgBwAHUAdAAgAGkAZAA9ACIAZgBvAHUAcgAiACAALwA%2BAAoAIAAgADwAbABhAGIAZQBsACAAaAB0AG0AbABGAG8AcgA9ACIAZgBvAHUAcgAiAD4AewAnAEEAcABwAGEAcgBlAG4AdABsAHkAIAB0AGgAaQBzACAAaQBzACAAYQBsAHMAbwAgAG4AbwB0ACAAbwBrAGEAeQAnAH0APAAvAGwAYQBiAGUAbAA%2BAAoAIAAgAAoAIAAgADwAaQBuAHAAdQB0ACAAaQBkAD0AIgBmAGkAdgBlACIAIAAvAD4ACgAgACAAPABsAGEAYgBlAGwAIABoAHQAbQBsAEYAbwByAD0AIgBmAGkAdgBlACIAPgBUAGgAYQBuAGsAZgB1AGwAbAB5ACAAewAnAGEAdAAgAGwAZQBhAHMAdAAgAHQAaABpAHMAIABpAHMAIABvAGsAYQB5ACcAfQA8AC8AbABhAGIAZQBsAD4ACgA8AC8APgA%3D

Expected result

Labels that are statically analyzable to confirm they will result in a non-empty string should not be reported as errors.

This was not happening in 1.8.3, started showing up in 1.9.0.

Code of Conduct

• I agree to follow Biome's Code of Conduct

[lifeiscontent]

defining a label as a component also has issues:

https://biomejs.dev/playground/?code=YwBvAG4AcwB0ACAAbABhAGIAZQBsACAAPQAgACIAVABoAGkAcwAgAGkAcwAgAG4AbwB0ACAAbwBrAGEAeQAiADsACgAKAGYAdQBuAGMAdABpAG8AbgAgAEwAYQBiAGUAbAAoAHAAcgBvAHAAcwA6ACAAUgBlAGEAYwB0AC4AQwBvAG0AcABvAG4AZQBuAHQAUAByAG8AcABzAFcAaQB0AGgAbwB1AHQAUgBlAGYAPAAnAGwAYQBiAGUAbAAnAD4AKQAgAHsACgAgACAAcgBlAHQAdQByAG4AIAA8AGwAYQBiAGUAbAAgAHsALgAuAC4AcAByAG8AcABzAH0AIAAvAD4AOwAKAH0ACgAKADwAPgAKACAAIAA8AGkAbgBwAHUAdAAgAGkAZAA9ACIAbwBuAGUAIgAgAC8APgAKACAAIAB7AC8AKgAgAFUAbgBkAGUAcgBzAHQAYQBuAGQAYQBiAGwAeQAgAG4AbwB0ACAAbwBrAGEAeQAgACoALwB9AAoAIAAgADwAbABhAGIAZQBsACAAaAB0AG0AbABGAG8AcgA9ACIAbwBuAGUAIgA%2BADwALwBsAGEAYgBlAGwAPgAKACAAIAAKACAAIAA8AGkAbgBwAHUAdAAgAGkAZAA9ACIAdAB3AG8AIgAgAC8APgAKACAAIAA8AGwAYQBiAGUAbAAgAGgAdABtAGwARgBvAHIAPQAiAHQAdwBvACIAPgBUAGgAaQBzACAAaQBzACAAbwBrAGEAeQA8AC8AbABhAGIAZQBsAD4ACgAgACAACgAgACAAPABpAG4AcAB1AHQAIABpAGQAPQAiAHQAaAByAGUAZQAiACAALwA%2BAAoAIAAgADwAbABhAGIAZQBsACAAaAB0AG0AbABGAG8AcgA9ACIAdABoAHIAZQBlACIAPgB7AGwAYQBiAGUAbAB9ADwALwBsAGEAYgBlAGwAPgAKACAAIAAKACAAIAA8AGkAbgBwAHUAdAAgAGkAZAA9ACIAZgBvAHUAcgAiACAALwA%2BAAoAIAAgADwAbABhAGIAZQBsACAAaAB0AG0AbABGAG8AcgA9ACIAZgBvAHUAcgAiAD4AewAnAEEAcABwAGEAcgBlAG4AdABsAHkAIAB0AGgAaQBzACAAaQBzACAAYQBsAHMAbwAgAG4AbwB0ACAAbwBrAGEAeQAnAH0APAAvAGwAYQBiAGUAbAA%2BAAoAIAAgAAoAIAAgADwAaQBuAHAAdQB0ACAAaQBkAD0AIgBmAGkAdgBlACIAIAAvAD4ACgAgACAAPABsAGEAYgBlAGwAIABoAHQAbQBsAEYAbwByAD0AIgBmAGkAdgBlACIAPgBUAGgAYQBuAGsAZgB1AGwAbAB5ACAAewAnAGEAdAAgAGwAZQBhAHMAdAAgAHQAaABpAHMAIABpAHMAIABvAGsAYQB5ACcAfQA8AC8AbABhAGIAZQBsAD4ACgAKACAAIAA8AGkAbgBwAHUAdAAgAGkAZAA9ACIAcwBpAHgAIgAgAC8APgAKACAAIAA8AEwAYQBiAGUAbAAgAGgAdABtAGwARgBvAHIAPQAiAHMAaQB4ACIAPgBUAGgAaQBzACAAaQBzACAAYQBsAHMAbwAgAGEAbgAgAGkAcwBzAHUAZQA8AC8ATABhAGIAZQBsAD4ACgA8AC8APgA%3D

[wojtekmaj]

@lifeiscontent Have you tried configuring the rule? Specifically I'm talking about labelComponents.

https://biomejs.dev/linter/rules/no-label-without-control/

[signalkuppe]

same here, this fails noLabelWithoutControl

<label htmlFor="lang-switcher">{t("Language")}</label>

[lifeiscontent]

@wojtekmaj yes, I would have in the playground, but no option to change the config from what I can tell

[othegagan]

@Conaclos how can i config or disable this rule noLabelWithoutControl in biome.js file.

Thank You, for your support

[Conaclos]

@othegagan

{
  "linter": {
    "rules": {
      "a11y": {
        "noLabelWithoutControl": "off"
      }
    }
  }
}

[othegagan]

I am getting this warning, (I have biome 1.9.2 installed )

[ematipico]

You're probably using an old version of the schema

[othegagan]

Yep, i just saw the $schema, in the config it was 1.8.3 but i had installed 1.9.2, after changing it to latest one it is working fine, i am able to disable this rule..

Thank You 😎👍

[ematipico]

@othegagan

We always recommend running biome migrate --write after a version bump, the command will update the configuration for you