-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 biome processing .vscode/*.txt that it shouldn't #4391
Comments
What kind of error does Biome output? |
Things like string should be in qoutes. |
Is it possible that your editor is mapping those files to another language? Is it possible that there's an extension that does that? To make sure it's Biome and not something in your editor, always use the CLI. |
It is cli, not ide |
It seems those files are parsed as JSON files |
@Conaclos could you please a look at this issue? I found the bug, the function that pull the known JSON files is incorrectly assuming that all files inside the known folders are JSON files: if let Some(Component::Normal(parent_dir)) = path.components().rev().nth(1) {
if Self::is_well_known_json_allow_comments_directory(parent_dir) {
return Ok(Self::json_allow_comments());
}
} This is incorrect, it seems, and we should still look at the extension of the file. |
Environment information
What happened?
It is scanning and processing
.txt
file it shouldn't.https://github.com/repobuddy/storybook-addon-vis/tree/biome-txt
The repo above has ignored any addition configs that doesn't matter already.
Expected result
no error
Code of Conduct
The text was updated successfully, but these errors were encountered: