Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regex for PR is too restrictive #45

Closed
cmungall opened this issue May 24, 2021 · 3 comments
Closed

regex for PR is too restrictive #45

cmungall opened this issue May 24, 2021 · 3 comments
Assignees
@cthoyt
Labels
Regex Related to regular expression patterns Update Used in combination with prefix, metaprefix, or collection for updates to entries

Comments

@cmungall
Copy link
Contributor

http://bioregistry.io/registry/pr

Pattern
^PR:P?\d+$

there are in fact PR:Onnnns...
@cmungall
Copy link
Contributor Author

also isoforms, e.g. PR:Pnnnnn-N

@cthoyt cthoyt self-assigned this May 24, 2021
@cthoyt
Copy link
Member

cthoyt commented May 25, 2021

I made a regular expression report at https://bioregistry.github.io/regex-report/ so we can streamline fixing some regexes

@cthoyt cthoyt added Regex Related to regular expression patterns Update Used in combination with prefix, metaprefix, or collection for updates to entries labels Jun 8, 2021
@cthoyt
Copy link
Member

cthoyt commented Apr 16, 2024

This was addressed in #959

@cthoyt cthoyt closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cthoyt cthoyt

Labels
Regex Related to regular expression patterns Update Used in combination with prefix, metaprefix, or collection for updates to entries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmungall @cthoyt