Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow users to specify which APIs to include (or exclude) #153

Closed
andrewsu opened this issue Apr 20, 2021 · 7 comments
Closed

allow users to specify which APIs to include (or exclude) #153

andrewsu opened this issue Apr 20, 2021 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@andrewsu
Copy link
Member

Ideally, individual end users would be able to specify individual APIs which should be included or excluded relative to a set of defaults. People may use this:

  • because some APIs may only be relevant in a small subset of use cases (e.g., ICEES for clinical data), or
  • because users may want to ignore data from an individual source (e.g., text-mined results from SEMMED), or
  • because an API is not behaving well and somehow disrupting overall BTE execution.

Unclear to me how one would pass in these user-specific, query-time parameters, but I think it would be useful...

Note, this is a mirror of #85 on the python client

@colleenXu
Copy link
Collaborator

Can be addressed in local instances using #255.

Not sure about specifying this on a query level (where it would work on the prod server).

@colleenXu
Copy link
Collaborator

not sure how relevant this is, since I don't think there's an option to do this in the TRAPI query (aka BTE's input).

@tokebe tokebe added the enhancement New feature or request label May 12, 2022
@tokebe
Copy link
Member

tokebe commented May 12, 2022

I assume this would not be adequately covered by reasoner_ids in the TRAPI query specification, in which case the only way could adequately support this is by taking an optional parameter in the request body, which wouldn't be technically TRAPI-compliant?

@colleenXu
Copy link
Collaborator

@tokebe I think some things have changed since this issue was opened.

Looks like TRAPI working group is looking at this a bit, but I don't know how far along they are. It looks like some ARAs implement this already. NCATSTranslator/ReasonerAPI#318

A related proposal also seems kinda complicated to me NCATSTranslator/ReasonerAPI#324

@andrewsu
Copy link
Member Author

andrewsu commented May 3, 2023

off priority list for now leaving open as new dev project

@andrewsu andrewsu closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2023
@andrewsu andrewsu added the help wanted Extra attention is needed label May 3, 2023
@andrewsu andrewsu reopened this May 3, 2023
@colleenXu
Copy link
Collaborator

Theoretically this is how to specify what resources to include / exclude in a TRAPI query. However, it's not clear what happens with TRAPI 1.4 where the provenance isn't stored in the edge-attributes anymore... https://github.com/NCATSTranslator/ReasonerAPI/blob/master/ImplementationRules.md#specifying-permitted-and-excluded-kps-to-an-ara

@andrewsu
Copy link
Member Author

this one is of sufficiently low priority that I'm going to close it as not planned

@tokebe tokebe closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants