-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a new test for proper edge merging #411
Comments
@tokebe What exactly is a simplified internal object and how would I go about creating/testing it? |
@rjawesome You can save You'll want to write this test in the query_graph_handler test files -- The behavior you'll be testing was fixed by this PR, which hopefully gives an idea of where to start. If not, shoot me a message and I can try to clarify what part of query execution this test should be focused on. From here you can write a test which supplies these records and expects specific edge-merging behavior (as shown in the original issue). You'll need to import the Record class and "un-freeze" your saved objects. |
@tokebe To confirm, these are the two things to test:
Is there anything else that I am missing? |
You only need to test that records that are otherwise the same but have different predicates are not merged into one response edge/result. No worries for |
As noted by @andrewsu, #390 is a good issue to turn into a module-level test for proper edge merging.
This query is a good test query to create simplified internal objects for this test
The text was updated successfully, but these errors were encountered: