api-response-transform: adjust the if-elseif statements?

[colleenXu]

The if-elseif logic for api-response-transform seems somewhat confusing, obsolete, or inexact:

1. api name starts with 'SEMMED':
   • I don't think anything in the registry meets this criteria. This statement and its transformer may be obsolete
2. api tags include "ctd" or "opentarget":
   • I'm not sure how reliable the existence of these tags are. They're not "basically required" the way the "biothings" tag is for BioThings APIs (based on our 2023-09-27 lab meeting discussion of SmartAPI tags)
   • maybe replace with api-name or smartAPI registration ID matching (see point 3)
   • but maybe this logic could be kept and I could add yaml comments saying these tags cannot be removed or changed because BTE depends on them...
3. api name (string match "==", used for ebi and biolink/monarch)
   • is it possible / preferable to use the SmartAPI registration IDs instead? I'm not sure...

Also, the use of the tag "bte-trapi": I found this confusing because it doesn't seem to be a tag in SmartAPI yamls. Instead, it seems to be something that BTE adds internally, maybe to track MetaEdges that come from TRAPI APIs in BTE's API_LIST config.

But I'm not sure if we want to adjust this logic (use the "trapi" tag instead?) or change this tag ("trapi-from-bte-api-list"?) because I found "bte-trapi" used in multiple BTE repos...

---

Context: @tokebe Jackson and I noticed this while working on #489 and reviewing biothings/api-respone-transform.js#38. But we agreed that it was out-of-scope for the JQ issue.

[tokebe]

Probably will be at least partially addressed by #825